Fix disappearing page actions bug.

chrome/browser/ui/views/location_bar/location_bar_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 283 matching lines @@
   // The same, but for the top and bottom edges.
   int vertical_edge_thickness() const {
     return is_popup_mode_ ? kPopupEdgeThickness : kNormalEdgeThickness;
   }
 
   // Updates the visibility state of the Content Blocked icons to reflect what
   // is actually blocked on the current page. Returns true if the visibility
   // of at least one of the views in |content_setting_views_| changed.
   bool RefreshContentSettingViews();
 
-  // Deletes all page action views that we have created.
-  void DeletePageActionViews();
+  // Deletes all page actions and page action views that we have created.
+  void DeletePageActionsAndViews();
 
   // Updates the views for the Page Actions, to reflect state changes for
   // PageActions. Returns true if the visibility of a PageActionWithBadgeView
   // changed, or PageActionWithBadgeView were created/destroyed.
   bool RefreshPageActionViews();
 
   // Updates the view for the zoom icon based on the current tab's zoom. Returns
   // true if the visibility of the view changed.
   bool RefreshZoomView();
 
@@ skipping 151 matching lines @@
   // A bubble that shows after successfully generating a new credit card number.
   GeneratedCreditCardView* generated_credit_card_view_;
 
   // The icon to open a PDF in Reader.
   OpenPDFInReaderView* open_pdf_in_reader_view_;
 
   // The manage passwords icon.
   ManagePasswordsIconView* manage_passwords_icon_view_;
 
   // The current page actions.
+  // There should be a 1:1 correspondence between elements of |page_actions_|
+  // and elements of |page_action_views_|.
   PageActions page_actions_;
 
   // The page action icon views.
+  // There should be a 1:1 correspondence between elements of |page_actions_|
+  // and elements of |page_action_views_|.
   PageActionViews page_action_views_;

[danduong, 2014/12/20 03:17:02]

page_action_views_ actually have a ref their corresponding page_action.  I think
we can just drop the page_actions_ altogether.

[erikchen, 2014/12/22 20:39:43]

Yup, done.

 
   // The icon for Translate.
   TranslateIconView* translate_icon_view_;
 
   // The star.
   StarView* star_view_;
 
   // The search/go button.
   SearchButton* search_button_;
 
@@ skipping 55 matching lines @@
   // The width is always positive.  The ending width is the width of the entire
   // omnibox URL.  As the show animation runs, the current width gradually moves
   // from the width of the hostname to the ending value.
   int current_omnibox_width_;
   int ending_omnibox_width_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_