add readPixels to SkImage

add readPixels to SkImage

remove "helper" readPixels from surface -- not well defined regarding the colortype of the result.

abandoning in favor of https://codereview.chromium.org/793723002

BUG=skia:3216
R=robertphillips@google.com

[reed2, 2014-12-10 04:20:35]

The CQ bit was checked by reed@chromium.org

[reed2, 2014-12-10 04:20:53]

reed@chromium.org changed reviewers:
+ robertphillips@google.com

[commit-bot: I haz the power, 2014-12-10 04:21:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789673007/1

[commit-bot: I haz the power, 2014-12-10 04:21:04]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-10 10:21 UTC

[commit-bot: I haz the power, 2014-12-10 10:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 10:21:03]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[tfarina, 2014-12-10 14:19:53]

https://codereview.chromium.org/789673007/diff/1/src/core/SkImageInfo.cpp
File src/core/SkImageInfo.cpp (right):

https://codereview.chromium.org/789673007/diff/1/src/core/SkImageInfo.cpp#new...
src/core/SkImageInfo.cpp:84: bool SkReadPixelsRec::trim(int srcWidth, int
srcHeight) {
Hum, forgive my intromission, but why this is being implemented in
SkImageInfo.cpp rather than SkReadPixelsRec.cpp?

[reed1, 2014-12-10 15:21:58]

On 2014/12/10 14:19:53, tfarina wrote:
> https://codereview.chromium.org/789673007/diff/1/src/core/SkImageInfo.cpp
> File src/core/SkImageInfo.cpp (right):
> 
>
https://codereview.chromium.org/789673007/diff/1/src/core/SkImageInfo.cpp#new...
> src/core/SkImageInfo.cpp:84: bool SkReadPixelsRec::trim(int srcWidth, int
> srcHeight) {
> Hum, forgive my intromission, but why this is being implemented in
> SkImageInfo.cpp rather than SkReadPixelsRec.cpp?

Not sure where to land it or what to call it, but its private so for 1 function
I think its ok to share an related file.

[robertphillips, 2014-12-10 15:26:57]

lgtm + dox suggestion

https://codereview.chromium.org/789673007/diff/1/src/image/SkReadPixelsRec.h
File src/image/SkReadPixelsRec.h (right):

https://codereview.chromium.org/789673007/diff/1/src/image/SkReadPixelsRec.h#...
src/image/SkReadPixelsRec.h:12: 
// A helper class to abstract away some of the computation involved when
converting readPixels' parameters to actual pixels

?

[reed1, 2014-12-10 15:35:19]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-12-10 15:35:20]

https://codereview.chromium.org/789673007/diff/1/src/image/SkReadPixelsRec.h
File src/image/SkReadPixelsRec.h (right):

https://codereview.chromium.org/789673007/diff/1/src/image/SkReadPixelsRec.h#...
src/image/SkReadPixelsRec.h:12: 
On 2014/12/10 15:26:57, robertphillips wrote:
> // A helper class to abstract away some of the computation involved when
> converting readPixels' parameters to actual pixels
> 
> ?

Done.