Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 793723002: add readPixels to SkImage (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

dd readPixels to SkImage patch from issue 789673007 at patchset 1 (http://crrev.com/789673007#ps1) BUG=skia: Committed: https://skia.googlesource.com/skia/+/96472deea70169396b8e1f576e470138f55fdb1f

Patch Set 1 #

Patch Set 2 : add tests #

Total comments: 1

Patch Set 3 : use better name on test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -132 lines) Patch
M include/core/SkImage.h View 2 chunks +21 lines, -23 lines 0 comments Download
M include/core/SkSurface.h View 2 chunks +3 lines, -11 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +6 lines, -32 lines 0 comments Download
M src/core/SkImageInfo.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 3 chunks +15 lines, -43 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +4 lines, -11 lines 0 comments Download
A src/image/SkReadPixelsRec.h View 1 chunk +41 lines, -0 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 2 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
6 years ago (2014-12-10 15:37:06 UTC) #2
reed1
adding tests now...
6 years ago (2014-12-10 15:37:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793723002/20001
6 years ago (2014-12-10 16:23:38 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-10 16:23:39 UTC) #6
robertphillips
lgtm + dox suggestion https://codereview.chromium.org/793723002/diff/20001/tests/SurfaceTest.cpp File tests/SurfaceTest.cpp (right): https://codereview.chromium.org/793723002/diff/20001/tests/SurfaceTest.cpp#newcode132 tests/SurfaceTest.cpp:132: // test SkImage's readPixels entry ...
6 years ago (2014-12-10 17:03:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793723002/40001
6 years ago (2014-12-10 17:44:35 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-10 17:53:47 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/96472deea70169396b8e1f576e470138f55fdb1f

Powered by Google App Engine
This is Rietveld 408576698