bookmarks: Use On*Clicked for naming an event method.

chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h

Index: chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h b/chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h
index de31a13f91a2bc193bec6a8ef7e4b079e80b6992..a6bd01f2c4071783ed8cf72effbaa9be514ba170 100644
--- a/chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h
+++ b/chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h
@@ -9,7 +9,7 @@
 // bookmarks.
 class BookmarkBarInstructionsDelegate {
  public:
-  virtual void ShowImportDialog() = 0;
+  virtual void OnImportLinkClicked() = 0;

[tfarina, 2014/12/12 00:58:47]

It feels/read better to me.

Like BookmarkBubbleDelegate's OnSignInLinkClicked:
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo...

[sky, 2014/12/12 15:46:45]

I'm ok with a new name here, but I think this should be exlicit and I don't
think it needs 'link' in the name. I'm thinking of OnImportBookmarks()

[tfarina, 2014/12/12 21:12:32]

Done.

 
  protected:
   virtual ~BookmarkBarInstructionsDelegate() {}