chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h - Issue 789653004: bookmarks: Use On*Clicked for naming an event method.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h

Issue 789653004: bookmarks: Use On*Clicked for naming an event method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_	5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_

6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_	6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_

7	7

8 // The delegate is notified once the user clicks on the link to import	8 // The delegate is notified once the user clicks on the link to import

9 // bookmarks.	9 // bookmarks.

10 class BookmarkBarInstructionsDelegate {	10 class BookmarkBarInstructionsDelegate {

11 public:	11 public:

12 virtual void ShowImportDialog() = 0;	12 virtual void OnImportLinkClicked() = 0;
	tfarina 2014/12/12 00:58:47 It feels/read better to me. Like BookmarkBubbleDe It feels/read better to me. Like BookmarkBubbleDelegate's OnSignInLinkClicked: https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo... sky 2014/12/12 15:46:45 I'm ok with a new name here, but I think this shou Show quoted text On 2014/12/12 00:58:47, tfarina wrote: > It feels/read better to me. > > Like BookmarkBubbleDelegate's OnSignInLinkClicked: > https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo... I'm ok with a new name here, but I think this should be exlicit and I don't think it needs 'link' in the name. I'm thinking of OnImportBookmarks() tfarina 2014/12/12 21:12:32 Done. Show quoted text On 2014/12/12 15:46:45, sky wrote: > On 2014/12/12 00:58:47, tfarina wrote: > > It feels/read better to me. > > > > Like BookmarkBubbleDelegate's OnSignInLinkClicked: > > > https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo... > > I'm ok with a new name here, but I think this should be exlicit and I don't > think it needs 'link' in the name. I'm thinking of OnImportBookmarks() Done.
13	13

14 protected:	14 protected:

15 virtual ~BookmarkBarInstructionsDelegate() {}	15 virtual ~BookmarkBarInstructionsDelegate() {}

16 };	16 };

17	17

18 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_	18 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_DELEGATE_H_

OLD	NEW