bookmarks: Use On*Clicked for naming an event method.

bookmarks: Use OnImportBookmarks for naming instructions delegate method.

Do not use an action when naming an event that will be fired to the
delegate. Instead of saying what the delegate should do or will do, just
say what event happened. So in this case, say to the delegate that the
instructions import link on the Bookmarks Bar was clicked.

BUG=None
TEST=have zero bookmarks in your Bookmarks Bar, so you can see the link there,
click on it to show the import dialog. No regressions should be observed.
R=sky@chromium.org

Committed: https://crrev.com/c2e7bc233673f8f6df7092ea523bca7d2a6b96ef
Cr-Commit-Position: refs/heads/master@{#308291}

[tfarina, 2014-12-12 00:58:47]

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
File chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h (right):

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h:12: virtual
void OnImportLinkClicked() = 0;
It feels/read better to me.

Like BookmarkBubbleDelegate's OnSignInLinkClicked:
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo...

[sky, 2014-12-12 15:46:46]

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
File chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h (right):

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h:12: virtual
void OnImportLinkClicked() = 0;
On 2014/12/12 00:58:47, tfarina wrote:
> It feels/read better to me.
> 
> Like BookmarkBubbleDelegate's OnSignInLinkClicked:
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo...

I'm ok with a new name here, but I think this should be exlicit and I don't
think it needs 'link' in the name. I'm thinking of OnImportBookmarks()

[tfarina, 2014-12-12 21:12:32]

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
File chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h (right):

https://codereview.chromium.org/789653004/diff/1/chrome/browser/ui/bookmarks/...
chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h:12: virtual
void OnImportLinkClicked() = 0;
On 2014/12/12 15:46:45, sky wrote:
> On 2014/12/12 00:58:47, tfarina wrote:
> > It feels/read better to me.
> > 
> > Like BookmarkBubbleDelegate's OnSignInLinkClicked:
> >
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/boo...
> 
> I'm ok with a new name here, but I think this should be exlicit and I don't
> think it needs 'link' in the name. I'm thinking of OnImportBookmarks()

Done.

[sky, 2014-12-12 23:58:57]

LGTM

[tfarina, 2014-12-14 01:31:15]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-12-14 01:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789653004/20001

[commit-bot: I haz the power, 2014-12-14 02:16:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-14 02:17:12]

Patchset 2 (id:??) landed as
https://crrev.com/c2e7bc233673f8f6df7092ea523bca7d2a6b96ef
Cr-Commit-Position: refs/heads/master@{#308291}