Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 789643002: Get rid of LayerFragment. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of LayerFragment. We don't have fragmentation. So no need for this abstraction. This simplifies a lot of code so that we can do less work. For example, we can check shouldPaintContent only up in paintLayerContents instead of in each nested function. Instead of passing the LayerFragment, pass the layer location and the clip rect for each nested function. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9c0e21b11665b34ec12af0572e25438e70c9da11

Patch Set 1 #

Patch Set 2 : rename methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -187 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/rendering/LayerFragment.h View 1 chunk +0 lines, -52 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 2 chunks +14 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 5 chunks +81 lines, -123 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
6 years ago (2014-12-09 01:35:01 UTC) #2
ojan
6 years ago (2014-12-09 01:37:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c0e21b11665b34ec12af0572e25438e70c9da11.

Powered by Google App Engine
This is Rietveld 408576698