Moved remaining legacy viewport tests to unit tests.

Moved remaining legacy viewport tests to unit tests.

In https://codereview.chromium.org/48613005/ most of the legacy viewport
meta tag tests were converted into unit tests. This CL moves the
remaining "trickier" tests.

I've also cleaned up the unit test infrastructure for viewport tests:
I've removed references to fixed layout mode unless the test was
actually still using it.
I've added a way to replace the viewport UA style sheet for testing.

BUG=314001

[bokan, 2013-11-21 20:16:16]

I've split the old CL into two (still a little big, but hopefully better). This
CL has some cleanup and moves the remaining Legacy tests to unit tests. Once
this lands I can rebase the second CL over this and put it up.

[kenneth.r.christiansen, 2013-11-21 20:30:36]

I still find it huge, but I know the amount of work it will be splitting it
further up.

I tried looking over it and hope that I didn't miss anything important.

Only worry is the mixture of changes here and the lack of comments in the unit
tests.

So lgtm, but you might want to have someone else have a more detailed look.

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/LegacyViewpo...
File Source/web/tests/LegacyViewportTest.cpp (right):

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/LegacyViewpo...
Source/web/tests/LegacyViewportTest.cpp:2718: EXPECT_EQ(320,
constraints.layoutSize.width());
I would love tests like these to have a comment above each group explaining at
least that happens and what should change from before... I would hate to debug
these tests

[bokan, 2013-11-21 20:37:59]

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/LegacyViewpo...
File Source/web/tests/LegacyViewportTest.cpp (right):

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/LegacyViewpo...
Source/web/tests/LegacyViewportTest.cpp:2718: EXPECT_EQ(320,
constraints.layoutSize.width());
On 2013/11/21 20:30:36, kenneth.r.christiansen wrote:
> I would love tests like these to have a comment above each group explaining at
> least that happens and what should change from before... I would hate to debug
> these tests

I agree, and I think going forward we should work on that. I moved these tests
over 'as-is' so there's no-more, no-less than what we had before. In this case,
I think most of the .html files have a descriptive <title> tag that should at
least provide a hint. Perhaps I'll move that title to here as a comment for each
test in another CL.

[bokan, 2013-11-26 19:24:51]

Rune, could you please have a look? If you're ok with it I'll add an OWNER.

[rune, 2013-11-27 09:59:55]

On 2013/11/26 19:24:51, bokan wrote:
> Rune, could you please have a look? If you're ok with it I'll add an OWNER.

I've looked at it briefly. I find it a bit harder to validate expectations with
unit tests, but that's the nature of it I guess.

Regarding OWNER, I think Kenneth is an OWNER now, so this should be possible to
land it based on his lgtm, or?

[kenneth.r.christiansen, 2013-11-27 10:36:40]

> Regarding OWNER, I think Kenneth is an OWNER now, so this should be possible
to
> land it based on his lgtm, or?

Only for core/ we need owner lgtm for web/

[bokan, 2013-11-27 17:55:55]

+abarth for OWNER

[abarth-chromium, 2013-11-27 18:40:36]

aelias is a better reviewer for this CL, but it looks like he's out-of-office
for a bit.

[abarth-chromium, 2013-11-27 18:43:50]

I don't really feel comfortable reviewing this CL.  There's a trade-off to
evaluate here and I don't think I understand enough to make a good decision
here.

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
File Source/web/tests/FrameTestHelpers.cpp (right):

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
Source/web/tests/FrameTestHelpers.cpp:45: #include
"core/platform/ScrollbarTheme.h"
It's sad to have all these detailed dependencies.  The invasiveness of these
dependencies will make it harder to change this code in the future...

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
Source/web/tests/FrameTestHelpers.cpp:181: }
These seem fine because they're poking at well-defined knobs in the engine.

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
Source/web/tests/FrameTestHelpers.cpp:218: }
These seem a bit more questionable....

[bokan, 2013-11-27 19:20:10]

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
File Source/web/tests/FrameTestHelpers.cpp (right):

https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
Source/web/tests/FrameTestHelpers.cpp:218: }
On 2013/11/27 18:43:50, abarth wrote:
> These seem a bit more questionable....

Yah, this feels wrong but there seems to be no way to replace the UA stylesheet
and I'm not sure of a better way to do this. Could you recommend someone in this
space to have a look/provide guidance?

[abarth-chromium, 2013-11-27 19:38:06]

On 2013/11/27 19:20:10, bokan wrote:
>
https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
> File Source/web/tests/FrameTestHelpers.cpp (right):
> 
>
https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
> Source/web/tests/FrameTestHelpers.cpp:218: }
> On 2013/11/27 18:43:50, abarth wrote:
> > These seem a bit more questionable....
> 
> Yah, this feels wrong but there seems to be no way to replace the UA
stylesheet
> and I'm not sure of a better way to do this. Could you recommend someone in
this
> space to have a look/provide guidance?

Maybe we should provide a proper API to replace the UA stylesheet?

[bokan, 2013-11-27 19:49:03]

On 2013/11/27 19:38:06, abarth wrote:
> On 2013/11/27 19:20:10, bokan wrote:
> >
>
https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
> > File Source/web/tests/FrameTestHelpers.cpp (right):
> > 
> >
>
https://codereview.chromium.org/78963008/diff/1/Source/web/tests/FrameTestHel...
> > Source/web/tests/FrameTestHelpers.cpp:218: }
> > On 2013/11/27 18:43:50, abarth wrote:
> > > These seem a bit more questionable....
> > 
> > Yah, this feels wrong but there seems to be no way to replace the UA
> stylesheet
> > and I'm not sure of a better way to do this. Could you recommend someone in
> this
> > space to have a look/provide guidance?
> 
> Maybe we should provide a proper API to replace the UA stylesheet?

Yup, that sounds like the ideal solution, but I have no experience in the CSS
engine. Who should I talk with to point me in the right direction?

[abarth-chromium, 2013-12-02 19:26:32]

On 2013/11/27 19:49:03, bokan wrote:
> Yup, that sounds like the ideal solution, but I have no experience in the CSS
> engine. Who should I talk with to point me in the right direction?

I would probably ask ojan or eseidel.