Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: Source/web/tests/WebInputEventConversionTest.cpp

Issue 78963008: Moved remaining legacy viewport tests to unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebInputEventConversionTest.cpp
diff --git a/Source/web/tests/WebInputEventConversionTest.cpp b/Source/web/tests/WebInputEventConversionTest.cpp
index fac6a8302bea56c54f512fe021f6d4b3521e70a6..f6b085f30b5fb678803f6825b3fd9df047371b0c 100644
--- a/Source/web/tests/WebInputEventConversionTest.cpp
+++ b/Source/web/tests/WebInputEventConversionTest.cpp
@@ -49,6 +49,7 @@
using namespace blink;
using namespace WebCore;
+using blink::FrameTestHelpers::setViewportSettings;
namespace {
@@ -93,12 +94,11 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)
TEST(WebInputEventConversionTest, InputEventsScaling)
{
const std::string baseURL("http://www.test.com/");
- const std::string fileName("fixed_layout.html");
+ const std::string fileName("no_viewport_tag.html");
- URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
+ URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("no_viewport_tag.html"));
FrameTestHelpers::WebViewHelper webViewHelper;
- WebViewImpl* webViewImpl = toWebViewImpl(webViewHelper.initializeAndLoad(baseURL + fileName, true));
- webViewImpl->settings()->setViewportEnabled(true);
+ WebViewImpl* webViewImpl = toWebViewImpl(webViewHelper.initializeAndLoad(baseURL + fileName, true, 0, 0, setViewportSettings));
int pageWidth = 640;
int pageHeight = 480;
webViewImpl->resize(WebSize(pageWidth, pageHeight));
@@ -293,12 +293,11 @@ TEST(WebInputEventConversionTest, InputEventsScaling)
TEST(WebInputEventConversionTest, InputEventsTransform)
{
const std::string baseURL("http://www.test2.com/");
- const std::string fileName("fixed_layout.html");
+ const std::string fileName("no_viewport_tag.html");
- URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
+ URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("no_viewport_tag.html"));
FrameTestHelpers::WebViewHelper webViewHelper;
- WebViewImpl* webViewImpl = toWebViewImpl(webViewHelper.initializeAndLoad(baseURL + fileName, true));
- webViewImpl->settings()->setViewportEnabled(true);
+ WebViewImpl* webViewImpl = toWebViewImpl(webViewHelper.initializeAndLoad(baseURL + fileName, true, 0, 0, setViewportSettings));
int pageWidth = 640;
int pageHeight = 480;
webViewImpl->resize(WebSize(pageWidth, pageHeight));

Powered by Google App Engine
This is Rietveld 408576698