Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 789543004: Renumbering sandbox policy actions to fix bug found by VC++'s /analyze. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Renumbering sandbox policy actions to fix bug found by VC++'s /analyze. Warning was: src\sandbox\win\src\policy_engine_processor.cc(81) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. This change should have no effect because the kStopOnErrors policy is never requested. BUG=427616 Committed: https://crrev.com/4471c6a4b951804d211afb269d064a7cd4753acf Cr-Commit-Position: refs/heads/master@{#307988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M sandbox/win/src/policy_engine_processor.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
6 years ago (2014-12-08 23:33:47 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years ago (2014-12-11 20:14:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789543004/1
6 years ago (2014-12-11 20:16:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 23:08:48 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 23:09:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4471c6a4b951804d211afb269d064a7cd4753acf
Cr-Commit-Position: refs/heads/master@{#307988}

Powered by Google App Engine
This is Rietveld 408576698