Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: sandbox/win/src/policy_engine_processor.h

Issue 789543004: Renumbering sandbox policy actions to fix bug found by VC++'s /analyze. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/policy_engine_processor.h
diff --git a/sandbox/win/src/policy_engine_processor.h b/sandbox/win/src/policy_engine_processor.h
index 85c999e27e99e493779588e86488fc3941991a7f..9e416bd35fcb0860e8f2b3127ee4824c406847a1 100644
--- a/sandbox/win/src/policy_engine_processor.h
+++ b/sandbox/win/src/policy_engine_processor.h
@@ -63,18 +63,18 @@ enum PolicyResult {
};
// Policy evaluation flags
-// TODO(cpu): implement the options 0 & 4.
+// TODO(cpu): implement the options kStopOnErrors & kRankedEval.
//
// Stop evaluating as soon as an error is encountered.
-const uint32 kStopOnErrors = 0;
+const uint32 kStopOnErrors = 1;
// Ignore all non fatal opcode evaluation errors.
-const uint32 kIgnoreErrors = 1;
+const uint32 kIgnoreErrors = 2;
// Short-circuit evaluation: Only evaluate until opcode group that
// evaluated to true has been found.
-const uint32 kShortEval = 2;
+const uint32 kShortEval = 4;
// Discussed briefly at the policy design meeting. It will evaluate
// all rules and then return the 'best' rule that evaluated true.
-const uint32 kRankedEval = 4;
+const uint32 kRankedEval = 8;
// This class evaluates a policy-opcode stream given the memory where the
// opcodes are and an input 'parameter set'.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698