chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen/fullscreen_controller.cc ('K') | « chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc ('k') | chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc

diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc

index dac13010dc3bc215e7d92e6afaa6a77b959192e3..e5aee385714aa05dff749f1daca9be58900207bd 100644

--- a/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc

+++ b/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc

@@ -388,8 +388,8 @@ bool FullscreenControllerStateTest::InvokeEvent(Event event) {

case TAB_FULLSCREEN_FALSE: {

content::WebContents* const active_tab =

GetBrowser()->tab_strip_model()->GetActiveWebContents();

- GetFullscreenController()->

- ToggleFullscreenModeForTab(active_tab, event == TAB_FULLSCREEN_TRUE);

+ GetFullscreenController()->ToggleFullscreenModeForTab(

+ active_tab, GURL(), event == TAB_FULLSCREEN_TRUE);

// Activating/Deactivating tab fullscreen on a captured tab should not

// evoke a state change in the browser window.

if (active_tab->GetCapturerCount() > 0)