chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen/fullscreen_controller.cc ('K') | « chrome/browser/ui/fullscreen/fullscreen_controller.cc ('k') | chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

index fe3e579b0f4095563bff7c8f91e48ef05e2ea13f..7708304ef44650223624e74f0b4a5ded9da9df4b 100644

--- a/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

+++ b/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

@@ -160,7 +160,7 @@ void FullscreenControllerInteractiveTest::ToggleTabFullscreen_Internal(

WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();

do {

FullscreenNotificationObserver fullscreen_observer;

- browser()->ToggleFullscreenModeForTab(tab, enter_fullscreen);

+ browser()->ToggleFullscreenModeForTab(tab, GURL(), enter_fullscreen);

fullscreen_observer.Wait();

// Repeat ToggleFullscreenModeForTab until the correct state is entered.

// This addresses flakiness on test bots running many fullscreen

@@ -371,7 +371,7 @@ IN_PROC_BROWSER_TEST_F(

FullscreenNotificationObserver fullscreen_observer;

EXPECT_FALSE(browser()->window()->IsFullscreen());

EXPECT_FALSE(browser()->window()->IsFullscreenWithToolbar());

- browser()->ToggleFullscreenModeForTab(tab, true);

+ browser()->ToggleFullscreenModeForTab(tab, GURL(), true);

fullscreen_observer.Wait();

EXPECT_TRUE(browser()->window()->IsFullscreen());

EXPECT_FALSE(browser()->window()->IsFullscreenWithToolbar());