components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update webcontentsdelegateandroid Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen/fullscreen_controller.cc ('K') | « chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.h b/components/web_contents_delegate_android/web_contents_delegate_android.h

index 9a899bc6d50115c474603628e87e8f745071d635..2ad67f9621df4f593de4e4888935098db5b9a955 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -102,8 +102,10 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {

virtual bool TakeFocus(content::WebContents* source, bool reverse) override;

virtual void ShowRepostFormWarningDialog(

content::WebContents* source) override;

- virtual void ToggleFullscreenModeForTab(content::WebContents* web_contents,

- bool enter_fullscreen) override;

+ virtual void EnterFullscreenModeForTab(content::WebContents* web_contents,

+ const GURL& origin) override;

+ virtual void ExitFullscreenModeForTab(

+ content::WebContents* web_contents) override;

virtual bool IsFullscreenForTabOrPending(

const content::WebContents* web_contents) const override;

virtual void ShowValidationMessage(content::WebContents* web_contents,