chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update webcontentsdelegateandroid Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen/fullscreen_controller.cc ('K') | « chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

index e76c8cc737ee329a10497e20ab6df43f7164c033..7468889d6f86550d39ca4705fd327a10addae90a 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

@@ -39,7 +39,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, MAYBE_NonImmersiveFullscreen) {

scoped_ptr<FullscreenNotificationObserver> waiter(

new FullscreenNotificationObserver());

browser()->fullscreen_controller()->ToggleFullscreenModeForTab(

- web_contents, true);

+ web_contents, GURL(), true);

waiter->Wait();

}

ASSERT_FALSE(browser_view->immersive_mode_controller()->IsEnabled());