Fullscreen: make fullscreen requests come from RenderFrame

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 354 matching lines @@
                                   int request_id,
                                   const base::FilePath& path) {}
 
   // Returns true if the delegate will embed a WebContents-owned fullscreen
   // render widget.  In this case, the delegate may access the widget by calling
   // WebContents::GetFullscreenRenderWidgetHostView().  If false is returned,
   // WebContents will be responsible for showing the fullscreen widget.
   virtual bool EmbedsFullscreenWidget() const;
 
   // Called when the renderer puts a tab into or out of fullscreen mode.
+  // |origin| will always be empty when |enter_fullscreen| is false.

[Charlie Reis, 2014/12/10 00:51:21]

These comments help, but please first say what |origin| is for (i.e., what it
means when it isn't empty).

[mlamouri (slow - plz ping), 2014/12/10 15:47:02]

Done.

+  // |origin| can be empty when |enter_fullscreen| in which case the

[Charlie Reis, 2014/12/10 00:51:21]

when |enter_fullscreen| is true, in which case...

[mlamouri (slow - plz ping), 2014/12/10 15:47:02]

No longer exists.

+  // implementation is expected to use |web_contents|' origin instead.
   virtual void ToggleFullscreenModeForTab(WebContents* web_contents,
+                                          const GURL& origin,
                                           bool enter_fullscreen) {}
   virtual bool IsFullscreenForTabOrPending(
       const WebContents* web_contents) const;
 
   // Register a new handler for URL requests with the given scheme.
   // |user_gesture| is true if the registration is made in the context of a user
   // gesture.
   virtual void RegisterProtocolHandler(WebContents* web_contents,
                                        const std::string& protocol,
                                        const GURL& url,
@@ skipping 118 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_