Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 8e1c65719186c10b67c940f7db1b2df4e72556b3..5c5b2ce7b358d55dce5f01f654cff238a51b8008 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -440,7 +440,8 @@ class CONTENT_EXPORT WebContentsImpl
void HandleGestureEnd() override;
void RunFileChooser(RenderViewHost* render_view_host,
const FileChooserParams& params) override;
- void ToggleFullscreenMode(bool enter_fullscreen) override;
+ void EnterFullscreenMode(const GURL& origin) override;
+ void ExitFullscreenMode() override;
bool IsFullscreenForCurrentTab() const override;
void UpdatePreferredSize(const gfx::Size& pref_size) override;
void ResizeDueToAutoResize(const gfx::Size& new_size) override;
@@ -942,6 +943,11 @@ class CONTENT_EXPORT WebContentsImpl
void RemoveAllMediaPlayerEntries(RenderFrameHost* render_frame_host,
ActiveMediaPlayerMap* player_map);
+ // Helper used by EnterFullscreenMode and ExitFullscreenMode.
+ // |origin| will be empty iif |enter_fullscreen| is false.
+ // |origin| will be a valid url iif |enter_fullscreen| is true.
+ void ToggleFullscreenMode(const GURL& origin, bool enter_fullscreen);
+
// Adds/removes a callback called on creation of each new WebContents.
// Deprecated, about to remove.
static void AddCreatedCallback(const CreatedCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698