Fullscreen: make fullscreen requests come from RenderFrame

content/browser/renderer_host/render_view_host_impl.h

Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index bb2013a700d8c2550b4c7b2e66bad14ad2c58442..111403cf4eb5cb9054fd3f6cc6277f9f2e4cf2af 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -290,6 +290,10 @@ class CONTENT_EXPORT RenderViewHostImpl
   // Creates a full screen RenderWidget.
   void CreateNewFullscreenWidget(int route_id);
 
+  // Called from a RenderFrameHostImpl when Blink requests to go fullscreen.
+  // The |origin| is the origin of the last committed url of the frame.
+  void EnterFullscreen(const GURL& origin);

[mlamouri (slow - plz ping), 2014/12/08 20:21:57]

It would probably have been a better idea to go trough RenderFrameHostDelegate
but it would have made that CL even bigger because the change would have been
more disruptive.

I think it could be interesting to investigate that in a follow-up.

[Charlie Reis, 2014/12/10 00:51:21]

Hmm, it does seem like that would be a better option.

To do that, we would need RenderFrameHostImpl to be able to call WasResized and
RejectMouseLockOrUnlockIfNecessary, right?  Those are both widget methods, and
it makes sense for RenderFrameHostImpl to be able to call them (on its
render_view_host_ for now, and on its widget after RVH goes away).

Technically, we could already do it.  WasResized is public, and
RejectMouseLockOrUnlockIfNecessary is protected but RenderFrameHostImpl is a
friend of RenderViewHostImpl while we move code between the two.  That's kind of
violating the spirit of the friend declaration, though, since the method
actually lives in RenderWidgetHostImpl.  It would be better to make it public on
RWHI.

I wouldn't be opposed to doing that in this CL, but feel free to send a followup
CL for that if you prefer.

[mlamouri (slow - plz ping), 2014/12/10 15:47:02]

Done. But I had to move some things around. RenderViewHost had a
ExitFullscreen() method that was called by FullscreenController and
WebContentsImpl. I moved this to WebContents. I think it makes more sense
because FullscreenController is mostly working with WebContents and was using
RVH mostly for that. However, it's a bit odd to have WebContentsImpl
implementing WebContents::ExitFullscreen and
RenderFrameHostDelegate::ExitFullscreenMode...

[Charlie Reis, 2014/12/10 19:22:56]

I agree, this is much better.  And it's not a big deal to have two versions (one
called from below, one from above).

+
 #if defined(ENABLE_BROWSER_CDMS)
   MediaWebContentsObserver* media_web_contents_observer() {
     return media_web_contents_observer_.get();
@@ -355,7 +359,6 @@ class CONTENT_EXPORT RenderViewHostImpl
   void OnClose();
   void OnRequestMove(const gfx::Rect& pos);
   void OnDocumentAvailableInMainFrame(bool uses_temporary_zoom_level);
-  void OnToggleFullscreen(bool enter_fullscreen);
   void OnDidContentsPreferredSizeChange(const gfx::Size& new_size);
   void OnPasteFromSelectionClipboard();
   void OnRouteCloseEvent();