Fullscreen: make fullscreen requests come from RenderFrame

content/browser/renderer_host/render_view_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 272 matching lines @@
       const ViewHostMsg_CreateWindow_Params& params,
       SessionStorageNamespace* session_storage_namespace);
 
   // Creates a new RenderWidget with the given route id.  |popup_type| indicates
   // if this widget is a popup and what kind of popup it is (select, autofill).
   void CreateNewWidget(int route_id, blink::WebPopupType popup_type);
 
   // Creates a full screen RenderWidget.
   void CreateNewFullscreenWidget(int route_id);
 
+  // Called from a RenderFrameHostImpl when Blink requests to go fullscreen.
+  // The |origin| is the origin of the last committed url of the frame.
+  void EnterFullscreen(const GURL& origin);

[mlamouri (slow - plz ping), 2014/12/08 20:21:57]

It would probably have been a better idea to go trough RenderFrameHostDelegate
but it would have made that CL even bigger because the change would have been
more disruptive.

I think it could be interesting to investigate that in a follow-up.

[Charlie Reis, 2014/12/10 00:51:21]

Hmm, it does seem like that would be a better option.

To do that, we would need RenderFrameHostImpl to be able to call WasResized and
RejectMouseLockOrUnlockIfNecessary, right?  Those are both widget methods, and
it makes sense for RenderFrameHostImpl to be able to call them (on its
render_view_host_ for now, and on its widget after RVH goes away).

Technically, we could already do it.  WasResized is public, and
RejectMouseLockOrUnlockIfNecessary is protected but RenderFrameHostImpl is a
friend of RenderViewHostImpl while we move code between the two.  That's kind of
violating the spirit of the friend declaration, though, since the method
actually lives in RenderWidgetHostImpl.  It would be better to make it public on
RWHI.

I wouldn't be opposed to doing that in this CL, but feel free to send a followup
CL for that if you prefer.

[mlamouri (slow - plz ping), 2014/12/10 15:47:02]

Done. But I had to move some things around. RenderViewHost had a
ExitFullscreen() method that was called by FullscreenController and
WebContentsImpl. I moved this to WebContents. I think it makes more sense
because FullscreenController is mostly working with WebContents and was using
RVH mostly for that. However, it's a bit odd to have WebContentsImpl
implementing WebContents::ExitFullscreen and
RenderFrameHostDelegate::ExitFullscreenMode...

[Charlie Reis, 2014/12/10 19:22:56]

I agree, this is much better.  And it's not a big deal to have two versions (one
called from below, one from above).

+
 #if defined(ENABLE_BROWSER_CDMS)
   MediaWebContentsObserver* media_web_contents_observer() {
     return media_web_contents_observer_.get();
   }
 #endif
 
   int main_frame_routing_id() const {
     return main_frame_routing_id_;
   }
 
@@ skipping 45 matching lines @@
   void OnShowWidget(int route_id, const gfx::Rect& initial_pos);
   void OnShowFullscreenWidget(int route_id);
   void OnRunModal(int opener_id, IPC::Message* reply_msg);
   void OnRenderViewReady();
   void OnRenderProcessGone(int status, int error_code);
   void OnUpdateState(int32 page_id, const PageState& state);
   void OnUpdateTargetURL(const GURL& url);
   void OnClose();
   void OnRequestMove(const gfx::Rect& pos);
   void OnDocumentAvailableInMainFrame(bool uses_temporary_zoom_level);
-  void OnToggleFullscreen(bool enter_fullscreen);
   void OnDidContentsPreferredSizeChange(const gfx::Size& new_size);
   void OnPasteFromSelectionClipboard();
   void OnRouteCloseEvent();
   void OnRouteMessageEvent(const ViewMsg_PostMessage_Params& params);
   void OnStartDragging(const DropData& drop_data,
                        blink::WebDragOperationsMask operations_allowed,
                        const SkBitmap& bitmap,
                        const gfx::Vector2d& bitmap_offset_in_dip,
                        const DragEventSourceInfo& event_info);
   void OnUpdateDragCursor(blink::WebDragOperation drag_operation);
@@ skipping 107 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
 };
 
 #if defined(COMPILER_MSVC)
 #pragma warning(pop)
 #endif
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_