Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 789513004: Removing border attribute should remove the visual border (Closed)

Created:
6 years ago by rwlbuis
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing border attribute should remove the visual border When removing the border attribute the table should look the same as if the border attribute was never given. So when we notice the border attribute is removed, make sure m_borderAttr is set to false so the border will be removed visually. Behavior matches Firefox. BUG=436915 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186883

Patch Set 1 #

Patch Set 2 : Foo #

Patch Set 3 : Add test #

Total comments: 1

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M LayoutTests/fast/table/border-changes-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/border-remove-border-attribute.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/border-remove-border-attribute-expected.html View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/table/script-tests/border-changes.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
6 years ago (2014-12-10 02:18:43 UTC) #2
tkent
lgtm https://codereview.chromium.org/789513004/diff/40001/Source/core/html/HTMLTableElement.cpp File Source/core/html/HTMLTableElement.cpp (right): https://codereview.chromium.org/789513004/diff/40001/Source/core/html/HTMLTableElement.cpp#newcode412 Source/core/html/HTMLTableElement.cpp:412: DEFINE_STATIC_REF_WILL_BE_PERSISTENT(StylePropertySet, hiddenBorderStyle, (createBorderStyle(CSSValueHidden))); This change is not related ...
6 years ago (2014-12-10 02:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789513004/60001
6 years ago (2014-12-10 15:21:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40658)
6 years ago (2014-12-10 18:25:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789513004/60001
6 years ago (2014-12-10 19:02:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-10 21:51:53 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186883

Powered by Google App Engine
This is Rietveld 408576698