Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 789513004: Removing border attribute should remove the visual border (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/script-tests/border-changes.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLElement.cpp
diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp
index 5ab64fcbaada007cbea96431797b715ff08501b6..ca8bde5bf5f1102766ce8db7d2f9dec8d838a175 100644
--- a/Source/core/html/HTMLElement.cpp
+++ b/Source/core/html/HTMLElement.cpp
@@ -127,8 +127,10 @@ static inline CSSValueID unicodeBidiAttributeForDirAuto(HTMLElement* element)
unsigned HTMLElement::parseBorderWidthAttribute(const AtomicString& value) const
{
unsigned borderWidth = 0;
- if (value.isEmpty() || !parseHTMLNonNegativeInteger(value, borderWidth))
- return hasTagName(tableTag) ? 1 : borderWidth;
+ if (value.isEmpty() || !parseHTMLNonNegativeInteger(value, borderWidth)) {
+ if (hasTagName(tableTag) && !value.isNull())
+ return 1;
+ }
return borderWidth;
}
« no previous file with comments | « LayoutTests/fast/table/script-tests/border-changes.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698