Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 789433003: [cc] Add nearest neighbor filtering for PictureLayer. (Closed)

Created:
6 years ago by jackhou1
Modified:
6 years ago
Reviewers:
danakj, jamesr, jschuh
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[cc] Add nearest neighbor filtering for PictureLayer. Blink side here (depends on this CL): https://codereview.chromium.org/782693003/ BUG=317991 Committed: https://crrev.com/2422961898e84e420c0e12031ebb5147748ab490 Cr-Commit-Position: refs/heads/master@{#308289}

Patch Set 1 #

Patch Set 2 : Update cc_messages_unittest.cc #

Patch Set 3 : Update mojo stuff #

Patch Set 4 : Only SetNeedsDisplay|PushProperties if nearest_neighbor changed. #

Total comments: 12

Patch Set 5 : Address comments #

Patch Set 6 : Add RendererPixelTest.PictureDrawQuadNearestNeighbor #

Total comments: 4

Patch Set 7 : Add TileDrawQuadNearestNeighbor #

Patch Set 8 : Sync and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -56 lines) Patch
M cc/blink/web_image_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_image_layer_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 4 5 6 7 6 chunks +19 lines, -6 lines 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 3 4 5 6 13 chunks +128 lines, -15 lines 0 comments Download
M cc/output/software_renderer.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/quads/content_draw_quad_base.h View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/quads/content_draw_quad_base.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 5 chunks +26 lines, -15 lines 0 comments Download
M cc/quads/picture_draw_quad.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/quads/picture_draw_quad.cc View 4 chunks +6 lines, -2 lines 0 comments Download
M cc/quads/tile_draw_quad.h View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/quads/tile_draw_quad.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M cc/test/render_pass_test_common.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/common/cc_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
jackhou1
danakj, could you take a look?
6 years ago (2014-12-09 02:01:04 UTC) #2
danakj
https://codereview.chromium.org/789433003/diff/60001/cc/layers/picture_layer.cc File cc/layers/picture_layer.cc (right): https://codereview.chromium.org/789433003/diff/60001/cc/layers/picture_layer.cc#newcode212 cc/layers/picture_layer.cc:212: if (nearest_neighbor_ != nearest_neighbor) { if == return https://codereview.chromium.org/789433003/diff/60001/cc/layers/picture_layer.cc#newcode214 ...
6 years ago (2014-12-09 19:44:46 UTC) #3
jackhou1
https://codereview.chromium.org/789433003/diff/60001/cc/layers/picture_layer.cc File cc/layers/picture_layer.cc (right): https://codereview.chromium.org/789433003/diff/60001/cc/layers/picture_layer.cc#newcode212 cc/layers/picture_layer.cc:212: if (nearest_neighbor_ != nearest_neighbor) { On 2014/12/09 19:44:45, danakj ...
6 years ago (2014-12-10 01:04:15 UTC) #4
danakj
https://codereview.chromium.org/789433003/diff/100001/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/789433003/diff/100001/cc/output/renderer_pixeltest.cc#newcode1969 cc/output/renderer_pixeltest.cc:1969: base::FilePath(FILE_PATH_LITERAL("four_blue_green_checkers.png")), this test has the same output as the ...
6 years ago (2014-12-10 21:11:45 UTC) #5
jackhou1
https://codereview.chromium.org/789433003/diff/100001/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/789433003/diff/100001/cc/output/renderer_pixeltest.cc#newcode1969 cc/output/renderer_pixeltest.cc:1969: base::FilePath(FILE_PATH_LITERAL("four_blue_green_checkers.png")), On 2014/12/10 21:11:45, danakj wrote: > this test ...
6 years ago (2014-12-11 08:38:12 UTC) #6
danakj
Thanks, LGTM
6 years ago (2014-12-11 17:58:21 UTC) #7
jackhou1
jschuh, please review for OWNERS in content/common/ jamesr, please review for OWNERS in mojo/
6 years ago (2014-12-11 22:44:11 UTC) #9
jamesr
mojo/ lgtm
6 years ago (2014-12-11 23:27:01 UTC) #11
jschuh
ipc security lgtm. notes: single bool
6 years ago (2014-12-12 23:34:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789433003/140001
6 years ago (2014-12-13 22:26:37 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years ago (2014-12-13 23:41:09 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-13 23:42:03 UTC) #16
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/2422961898e84e420c0e12031ebb5147748ab490
Cr-Commit-Position: refs/heads/master@{#308289}

Powered by Google App Engine
This is Rietveld 408576698