Issue 789403004: Revert of Added test to check the state of ARIA checkboxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789403004: Revert of Added test to check the state of ARIA checkboxes. (Closed)

Created:
6 years ago by lushnikov

Modified:
6 years ago

Reviewers:
dmazzoni, k.czech

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Added test to check the state of ARIA checkboxes. (patchset #2 id:20001 of https://codereview.chromium.org/783113002/) Reason for revert: Speculative revert: test DumpAccessibilityTreeTest.AccessibilityAriaMenuItemRadio is failing on win8 Flakiness Dashboard: http://goo.gl/rvwUyf Example build: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/36678 Original issue's description: > Added test to check the state of ARIA checkboxes. > > Provided also some logic to check mixed state for > radio and menu item radio roles. W3c spec says to treat them as false. > > BUG=170576, 418013 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186852 TBR=dmazzoni@chromium.org,k.czech@samsung.com NOTREECHECKS=true NOTRY=true BUG=170576, 418013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186948

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -50 lines)			Patch
D	LayoutTests/accessibility/aria-checkbox-checked-mixed.html	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/modules/accessibility/AXObject.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

lushnikov

Created Revert of Added test to check the state of ARIA checkboxes.

6 years ago (2014-12-11 13:13:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789403004/1

6 years ago (2014-12-11 13:14:11 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-11 13:14:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186948