Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 789363002: TimelineBasedMeasurement(object) instead of TimelineBasedMeasurement(page_test.PageTest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update docs. Add PageTest guards. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/shared_page_state.py
diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py
index 88a360ddd0894ab4e15483ef17167fc2c0138599..84b23deb29522afb9244bea88660fcb6a9d35fae 100644
--- a/tools/telemetry/telemetry/page/shared_page_state.py
+++ b/tools/telemetry/telemetry/page/shared_page_state.py
@@ -18,6 +18,7 @@ from telemetry.user_story import shared_user_story_state
from telemetry.util import exception_formatter
from telemetry.util import file_handle
from telemetry.value import skip
+from telemetry.web_perf import timeline_based_measurement
def _PrepareFinderOptions(finder_options, test, page_set):
@@ -42,7 +43,10 @@ class SharedPageState(shared_user_story_state.SharedUserStoryState):
# TODO(slamm): Remove _append_to_existing_wpr when replay lifetime changes.
self._append_to_existing_wpr = False
self._first_browser = True
- self._test = test
+ self._test = (
+ timeline_based_measurement.TimelineBasedPageTest(test)
+ if isinstance(test, timeline_based_measurement.TimelineBasedMeasurement)
+ else test)
self._did_login_for_current_page = False
self._current_page = None
self._current_tab = None

Powered by Google App Engine
This is Rietveld 408576698