Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 789363002: TimelineBasedMeasurement(object) instead of TimelineBasedMeasurement(page_test.PageTest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update docs. Add PageTest guards. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import logging 4 import logging
5 import os 5 import os
6 import sys 6 import sys
7 7
8 from telemetry import decorators 8 from telemetry import decorators
9 from telemetry.core import browser_finder 9 from telemetry.core import browser_finder
10 from telemetry.core import browser_finder_exceptions 10 from telemetry.core import browser_finder_exceptions
11 from telemetry.core import browser_info 11 from telemetry.core import browser_info
12 from telemetry.core import exceptions 12 from telemetry.core import exceptions
13 from telemetry.core import util 13 from telemetry.core import util
14 from telemetry.core import wpr_modes 14 from telemetry.core import wpr_modes
15 from telemetry.core.platform.profiler import profiler_finder 15 from telemetry.core.platform.profiler import profiler_finder
16 from telemetry.page import page_test 16 from telemetry.page import page_test
17 from telemetry.user_story import shared_user_story_state 17 from telemetry.user_story import shared_user_story_state
18 from telemetry.util import exception_formatter 18 from telemetry.util import exception_formatter
19 from telemetry.util import file_handle 19 from telemetry.util import file_handle
20 from telemetry.value import skip 20 from telemetry.value import skip
21 from telemetry.web_perf import timeline_based_measurement
21 22
22 23
23 def _PrepareFinderOptions(finder_options, test, page_set): 24 def _PrepareFinderOptions(finder_options, test, page_set):
24 browser_options = finder_options.browser_options 25 browser_options = finder_options.browser_options
25 # Set up user agent. 26 # Set up user agent.
26 browser_options.browser_user_agent_type = page_set.user_agent_type or None 27 browser_options.browser_user_agent_type = page_set.user_agent_type or None
27 28
28 test.CustomizeBrowserOptions(finder_options.browser_options) 29 test.CustomizeBrowserOptions(finder_options.browser_options)
29 if finder_options.profiler: 30 if finder_options.profiler:
30 profiler_class = profiler_finder.FindProfiler(finder_options.profiler) 31 profiler_class = profiler_finder.FindProfiler(finder_options.profiler)
31 profiler_class.CustomizeBrowserOptions(browser_options.browser_type, 32 profiler_class.CustomizeBrowserOptions(browser_options.browser_type,
32 finder_options) 33 finder_options)
33 34
34 class SharedPageState(shared_user_story_state.SharedUserStoryState): 35 class SharedPageState(shared_user_story_state.SharedUserStoryState):
35 def __init__(self, test, finder_options, user_story_set): 36 def __init__(self, test, finder_options, user_story_set):
36 super(SharedPageState, self).__init__(test, finder_options, user_story_set) 37 super(SharedPageState, self).__init__(test, finder_options, user_story_set)
37 self.browser = None 38 self.browser = None
38 _PrepareFinderOptions(finder_options, test, user_story_set) 39 _PrepareFinderOptions(finder_options, test, user_story_set)
39 self._finder_options = finder_options 40 self._finder_options = finder_options
40 self._possible_browser = self._GetPossibleBrowser(test, finder_options) 41 self._possible_browser = self._GetPossibleBrowser(test, finder_options)
41 42
42 # TODO(slamm): Remove _append_to_existing_wpr when replay lifetime changes. 43 # TODO(slamm): Remove _append_to_existing_wpr when replay lifetime changes.
43 self._append_to_existing_wpr = False 44 self._append_to_existing_wpr = False
44 self._first_browser = True 45 self._first_browser = True
45 self._test = test 46 self._test = (
47 timeline_based_measurement.TimelineBasedPageTest(test)
48 if isinstance(test, timeline_based_measurement.TimelineBasedMeasurement)
49 else test)
46 self._did_login_for_current_page = False 50 self._did_login_for_current_page = False
47 self._current_page = None 51 self._current_page = None
48 self._current_tab = None 52 self._current_tab = None
49 53
50 self._test.SetOptions(self._finder_options) 54 self._test.SetOptions(self._finder_options)
51 55
52 def _GetPossibleBrowser(self, test, finder_options): 56 def _GetPossibleBrowser(self, test, finder_options):
53 ''' Return a possible_browser with the given options. ''' 57 ''' Return a possible_browser with the given options. '''
54 possible_browser = browser_finder.FindBrowser(finder_options) 58 possible_browser = browser_finder.FindBrowser(finder_options)
55 if not possible_browser: 59 if not possible_browser:
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 self.platform.profiling_controller.Start( 274 self.platform.profiling_controller.Start(
271 self._finder_options.profiler, output_file) 275 self._finder_options.profiler, output_file)
272 276
273 def _StopProfiling(self, results): 277 def _StopProfiling(self, results):
274 if self.browser: 278 if self.browser:
275 profiler_files = self.platform.profiling_controller.Stop() 279 profiler_files = self.platform.profiling_controller.Stop()
276 for f in profiler_files: 280 for f in profiler_files:
277 if os.path.isfile(f): 281 if os.path.isfile(f):
278 results.AddProfilingFile(self._current_page, 282 results.AddProfilingFile(self._current_page,
279 file_handle.FromFilePath(f)) 283 file_handle.FromFilePath(f))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698