Issue 7889026: Linux: add a tool to enforce licensecheck results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7889026: Linux: add a tool to enforce licensecheck results (Closed)

Created:
9 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 3 months ago

Reviewers:
Nico, Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Linux: add a tool to enforce licensecheck results with a looooong suppression list for current problems. BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101102

Patch Set 1 #

Total comments: 3

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+484 lines, -0 lines)			Patch
	A	tools/checklicenses/OWNERS	View		1 chunk	+3 lines, -0 lines	2 comments	Download
	A	tools/checklicenses/checklicenses.py	View		1 chunk	+481 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/checklicenses.py#newcode473 tools/checklicenses/checklicenses.py:473: option_parser.add_option('', '--root', default=default_root, You can leave out the ...

9 years, 3 months ago (2011-09-14 01:51:27 UTC) #2

Nico

http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS File tools/checklicenses/OWNERS (right): http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS#newcode1 tools/checklicenses/OWNERS:1: set noparent :-(

9 years, 3 months ago (2011-09-14 18:04:36 UTC) #3

Paweł Hajdan Jr.

9 years, 3 months ago (2011-09-14 18:06:36 UTC) #4

http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS
File tools/checklicenses/OWNERS (right):

http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS#newc...
tools/checklicenses/OWNERS:1: set noparent
On 2011/09/14 18:04:36, Nico wrote:
> :-(

Yes, so that people don't suppress new problems but fix them. Sorry about that.

Expand Messages | Collapse Messages