Chromium Code Reviews
Help | Chromium Project | Sign in
(38)

Issue 7889026: Linux: add a tool to enforce licensecheck results (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by Paweł Hajdan Jr.
Modified:
3 years, 9 months ago
Reviewers:
Nico, Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Linux: add a tool to enforce licensecheck results with a looooong suppression list for current problems. BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101102

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -0 lines) Patch
A tools/checklicenses/OWNERS View 1 chunk +3 lines, -0 lines 2 comments Download
A tools/checklicenses/checklicenses.py View 1 chunk +481 lines, -0 lines 1 comment Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
3 years, 9 months ago (2011-09-14 00:49:45 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/checklicenses.py#newcode473 tools/checklicenses/checklicenses.py:473: option_parser.add_option('', '--root', default=default_root, You can leave out the ...
3 years, 9 months ago (2011-09-14 01:51:27 UTC) #2
Nico
http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS File tools/checklicenses/OWNERS (right): http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS#newcode1 tools/checklicenses/OWNERS:1: set noparent :-(
3 years, 9 months ago (2011-09-14 18:04:36 UTC) #3
Paweł Hajdan Jr.
3 years, 9 months ago (2011-09-14 18:06:36 UTC) #4
http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS
File tools/checklicenses/OWNERS (right):

http://codereview.chromium.org/7889026/diff/1/tools/checklicenses/OWNERS#newc...
tools/checklicenses/OWNERS:1: set noparent
On 2011/09/14 18:04:36, Nico wrote:
> :-(

Yes, so that people don't suppress new problems but fix them. Sorry about that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d