Implementation of IDBFactory::getDatabaseNames

Implementation of IDBFactory::getDatabaseNames

WebKit side is: https://bugs.webkit.org/show_bug.cgi?id=68037

BUG=94439
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102743

[jsbell, 2011-09-13 23:31:41]

Corresponding WebKit patch pending.

[jsbell, 2011-09-13 23:47:25]

WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=68037

[dgrogan, 2011-09-14 01:25:19]

Oops, the sync v async comment should have been over here.

http://codereview.chromium.org/7889024/diff/1/content/browser/in_process_webk...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/7889024/diff/1/content/browser/in_process_webk...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:223: static
const uint64 kIncognitoSqliteBackendQuota = 50 * 1024 * 1024;
Get rid of this quota stuff, as elsewhere.

http://codereview.chromium.org/7889024/diff/1/content/browser/in_process_webk...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:225: //
TODO(dgrogan): Don't let a non-existing database be opened (and therefore
And this comment.

http://codereview.chromium.org/7889024/diff/1/content/common/indexed_db_messa...
File content/common/indexed_db_messages.h (right):

http://codereview.chromium.org/7889024/diff/1/content/common/indexed_db_messa...
content/common/indexed_db_messages.h:217:
IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_FactoryDatabaseNames,
This needs to be async, which will obviously complicate things.  You'll have to
plumb through a success message.

[jsbell, 2011-09-15 18:22:45]

Rewritten to be async, usage is:

var req = indexedDB.getDatabaseNames();
// req.result will be DOMStringList

When reviewing, pay attention to the result, which is marshaled across the IPC
boundary as a vector<string16>

[jsbell, 2011-09-15 18:24:02]

On 2011/09/14 01:25:19, dgrogan wrote:
http://codereview.chromium.org/7889024/diff/1/content/browser/in_process_webk...
> content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:223: static
> const uint64 kIncognitoSqliteBackendQuota = 50 * 1024 * 1024;
> Get rid of this quota stuff, as elsewhere.

Per discussion with dgrogan, leaving this in until we remove SQLite
implementation when it can be removed from both IDBFactory methods.

[dgrogan, 2011-09-15 21:25:39]

On 2011/09/15 18:22:45, jsbell wrote:
> Rewritten to be async, usage is:
> 
> var req = indexedDB.getDatabaseNames();
> // req.result will be DOMStringList
> 
> When reviewing, pay attention to the result, which is marshaled across the IPC
> boundary as a vector<string16>

This is as good as anything I'd come up with, so, pending some refactoring to
reuse logic from open, LGTM.

[dgrogan, 2011-09-15 21:25:56]

http://codereview.chromium.org/7889024/diff/6001/content/renderer/indexed_db_...
File content/renderer/indexed_db_dispatcher.h (right):

http://codereview.chromium.org/7889024/diff/6001/content/renderer/indexed_db_...
content/renderer/indexed_db_dispatcher.h:25: class WebDOMStringList;
nit: put this in alpha order

[jsbell, 2011-09-22 19:59:20]

Can you look at the latest patch? Includes nit fixes and removes extraneous
#includes

[dgrogan, 2011-09-22 20:00:52]

On 2011/09/22 19:59:20, jsbell wrote:
> Can you look at the latest patch? Includes nit fixes and removes extraneous
> #includes

LGTM

[commit-bot: I haz the power, 2011-09-23 20:51:58]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/7889024/16001

[commit-bot: I haz the power, 2011-09-23 20:52:04]

Presubmit check for 7889024-16001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/renderer/renderer_webidbfactory_impl.h,content/common/indexed_db_messages.h,content/renderer/renderer_webidbfactory_impl.cc,content/renderer/indexed_db_dispatcher.h,content/renderer/indexed_db_dispatcher.cc

Presubmit checks took 2.3s to calculate.

[jsbell, 2011-09-23 21:25:08]

jam@chromium.org, can you approve as an OWNER of content/renderer and
content/common ?

[jam, 2011-09-23 22:56:57]

lgtm

[commit-bot: I haz the power, 2011-09-23 23:31:25]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/7889024/16001

[commit-bot: I haz the power, 2011-09-23 23:56:58]

Try job failure for 7889024-16001 (retry) on linux_clang for steps
"update_clang, compile" (clobber build).
It's a second try, previously, steps "update_clang, compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Marc-Antoine Ruel (Google), 2011-09-24 00:49:42]

Nico??

Le 23 septembre 2011 19:56, <commit-bot@chromium.org> a écrit :

> Try job failure for 7889024-16001 (retry) on linux_clang for steps
> "update_clang, compile" (clobber build).
> It's a second try, previously, steps "update_clang, compile" failed.
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_**clang&number=8981<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=8981>
>
>
>
http://codereview.chromium.**org/7889024/<http://codereview.chromium.org/7889...
>

[(unused - use chromium), 2011-09-24 00:51:34]

/me shakes fist at posix

drover --revert 102494 is running, sorry

On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel <maruel@google.com> wrote:
> Nico??
>
> Le 23 septembre 2011 19:56, <commit-bot@chromium.org> a écrit :
>>
>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
>> "update_clang, compile" (clobber build).
>> It's a second try, previously, steps "update_clang, compile" failed.
>>
>>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>>
>> http://codereview.chromium.org/7889024/
>
>

[(unused - use chromium), 2011-09-24 00:52:25]

actually, drover doesn't work for tools, this laptop has no tools
checkout and no vpn. Is there some easy other way to revert this?

On Fri, Sep 23, 2011 at 5:51 PM, Nico Weber <thakis@google.com> wrote:
> /me shakes fist at posix
>
> drover --revert 102494 is running, sorry
>
> On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel <maruel@google.com> wrote:
>> Nico??
>>
>> Le 23 septembre 2011 19:56, <commit-bot@chromium.org> a écrit :
>>>
>>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
>>> "update_clang, compile" (clobber build).
>>> It's a second try, previously, steps "update_clang, compile" failed.
>>>
>>>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>>>
>>> http://codereview.chromium.org/7889024/
>>
>>
>

[(unused - use chromium), 2011-09-24 00:54:35]

(this was landed through CQ btw – does a red update_clang step not stop CQ?)

On Fri, Sep 23, 2011 at 5:52 PM, Nico Weber <thakis@google.com> wrote:
> actually, drover doesn't work for tools, this laptop has no tools
> checkout and no vpn. Is there some easy other way to revert this?
>
> On Fri, Sep 23, 2011 at 5:51 PM, Nico Weber <thakis@google.com> wrote:
>> /me shakes fist at posix
>>
>> drover --revert 102494 is running, sorry
>>
>> On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel <maruel@google.com> wrote:
>>> Nico??
>>>
>>> Le 23 septembre 2011 19:56, <commit-bot@chromium.org> a écrit :
>>>>
>>>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
>>>> "update_clang, compile" (clobber build).
>>>> It's a second try, previously, steps "update_clang, compile" failed.
>>>>
>>>>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>>>>
>>>> http://codereview.chromium.org/7889024/
>>>
>>>
>>
>

[dgrogan, 2011-09-24 00:58:40]

On 2011/09/24 00:54:35, thakis wrote:
> (this was landed through CQ btw – does a red update_clang step not stop
CQ?)

Looks like the CQ didn't do much for that patch:
https://chromium-status.appspot.com/cq/thakis%40chromium.org/7925013/1001

> On Fri, Sep 23, 2011 at 5:52 PM, Nico Weber <mailto:thakis@google.com> wrote:
> > actually, drover doesn't work for tools, this laptop has no tools
> > checkout and no vpn. Is there some easy other way to revert this?
> >
> > On Fri, Sep 23, 2011 at 5:51 PM, Nico Weber <mailto:thakis@google.com>
wrote:
> >> /me shakes fist at posix
> >>
> >> drover --revert 102494 is running, sorry
> >>
> >> On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel
<mailto:maruel@google.com> wrote:
> >>> Nico??
> >>>
> >>> Le 23 septembre 2011 19:56, <mailto:commit-bot@chromium.org> a écrit :
> >>>>
> >>>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
> >>>> "update_clang, compile" (clobber build).
> >>>> It's a second try, previously, steps "update_clang, compile" failed.
> >>>>
> >>>>
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
> >>>>
> >>>> http://codereview.chromium.org/7889024/
> >>>
> >>>
> >>
> >

[(unused - use chromium), 2011-09-24 01:08:07]

Sorry, wrong change number. 102596 is the right one

On Fri, Sep 23, 2011 at 5:58 PM,  <dgrogan@chromium.org> wrote:
> On 2011/09/24 00:54:35, thakis wrote:
>>
>> (this was landed through CQ btw –&nbsp;does a red update_clang step not
>> stop
>
> CQ?)
>
> Looks like the CQ didn't do much for that patch:
> https://chromium-status.appspot.com/cq/thakis%40chromium.org/7925013/1001
>
>> On Fri, Sep 23, 2011 at 5:52 PM, Nico Weber <mailto:thakis@google.com>
>> wrote:
>> > actually, drover doesn't work for tools, this laptop has no tools
>> > checkout and no vpn. Is there some easy other way to revert this?
>> >
>> > On Fri, Sep 23, 2011 at 5:51 PM, Nico Weber <mailto:thakis@google.com>
>
> wrote:
>>
>> >> /me shakes fist at posix
>> >>
>> >> drover --revert 102494 is running, sorry
>> >>
>> >> On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel
>
> <mailto:maruel@google.com> wrote:
>>
>> >>> Nico??
>> >>>
>> >>> Le 23 septembre 2011 19:56, <mailto:commit-bot@chromium.org> a écrit :
>> >>>>
>> >>>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
>> >>>> "update_clang, compile" (clobber build).
>> >>>> It's a second try, previously, steps "update_clang, compile" failed.
>> >>>>
>> >>>>
>
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>>
>> >>>>
>> >>>> http://codereview.chromium.org/7889024/
>> >>>
>> >>>
>> >>
>> >
>
>
>
> http://codereview.chromium.org/7889024/
>

[(unused - use chromium), 2011-09-24 01:09:14]

Reverted in r102631

On Fri, Sep 23, 2011 at 6:07 PM, Nico Weber <thakis@google.com> wrote:
> Sorry, wrong change number. 102596 is the right one
>
> On Fri, Sep 23, 2011 at 5:58 PM,  <dgrogan@chromium.org> wrote:
>> On 2011/09/24 00:54:35, thakis wrote:
>>>
>>> (this was landed through CQ btw –&nbsp;does a red update_clang step not
>>> stop
>>
>> CQ?)
>>
>> Looks like the CQ didn't do much for that patch:
>> https://chromium-status.appspot.com/cq/thakis%40chromium.org/7925013/1001
>>
>>> On Fri, Sep 23, 2011 at 5:52 PM, Nico Weber <mailto:thakis@google.com>
>>> wrote:
>>> > actually, drover doesn't work for tools, this laptop has no tools
>>> > checkout and no vpn. Is there some easy other way to revert this?
>>> >
>>> > On Fri, Sep 23, 2011 at 5:51 PM, Nico Weber <mailto:thakis@google.com>
>>
>> wrote:
>>>
>>> >> /me shakes fist at posix
>>> >>
>>> >> drover --revert 102494 is running, sorry
>>> >>
>>> >> On Fri, Sep 23, 2011 at 5:49 PM, Marc-Antoine Ruel
>>
>> <mailto:maruel@google.com> wrote:
>>>
>>> >>> Nico??
>>> >>>
>>> >>> Le 23 septembre 2011 19:56, <mailto:commit-bot@chromium.org> a écrit :
>>> >>>>
>>> >>>> Try job failure for 7889024-16001 (retry) on linux_clang for steps
>>> >>>> "update_clang, compile" (clobber build).
>>> >>>> It's a second try, previously, steps "update_clang, compile" failed.
>>> >>>>
>>> >>>>
>>
>>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>>>
>>> >>>>
>>> >>>> http://codereview.chromium.org/7889024/
>>> >>>
>>> >>>
>>> >>
>>> >
>>
>>
>>
>> http://codereview.chromium.org/7889024/
>>
>

[commit-bot: I haz the power, 2011-09-26 14:54:33]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/7889024/16001

[commit-bot: I haz the power, 2011-09-26 17:12:05]

Change committed as 102743