Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 788863003: Restore the JS Spinning Cube demo (Closed)

Created:
6 years ago by hansmuller
Modified:
6 years ago
Reviewers:
Aaron Boodman
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restore the JS Spinning Cube demo This version is only slightly changed from the original: - Started with the JS content handler - Uses classes, Application - Improved resize handling BUG= R=aa@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d168027f6830e07435b0c3fa0de0402c024260b4

Patch Set 1 #

Patch Set 2 : Pass along GL Context resize scale_factor #

Patch Set 3 : Removed spurious includes #

Total comments: 5

Patch Set 4 : Changes per review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -8 lines) Patch
M examples/js/README.md View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
A examples/js/cube.js View 1 2 3 1 chunk +416 lines, -0 lines 0 comments Download
M services/js/js_app_runner_delegate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M services/js/modules/gl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/js/modules/gl/context.h View 3 chunks +4 lines, -3 lines 0 comments Download
M services/js/modules/gl/context.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M services/js/modules/gl/module.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Aaron Boodman
lgtm neat, I'm really glad to see this back. https://codereview.chromium.org/788863003/diff/40001/examples/js/README.md File examples/js/README.md (right): https://codereview.chromium.org/788863003/diff/40001/examples/js/README.md#newcode8 examples/js/README.md:8: ...
6 years ago (2014-12-09 20:24:53 UTC) #2
hansmuller
Thanks for taking a look. https://codereview.chromium.org/788863003/diff/40001/examples/js/README.md File examples/js/README.md (right): https://codereview.chromium.org/788863003/diff/40001/examples/js/README.md#newcode16 examples/js/README.md:16: Where js-application-url is either ...
6 years ago (2014-12-09 20:43:21 UTC) #3
hansmuller
6 years ago (2014-12-09 20:44:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
d168027f6830e07435b0c3fa0de0402c024260b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698