Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7888067: Oops, missed a NULL check. Fix flaky test. (Closed)

Created:
9 years, 3 months ago by willchan no longer on Chromium
Modified:
9 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Oops, missed a NULL check. Fix flaky test. CancelRequests() needs to handle NULLs in sent_requests_. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101228

Patch Set 1 #

Patch Set 2 : Undid test, CancelRequests() can only be invoked in destructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/plugin_process_host.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
willchan no longer on Chromium
9 years, 3 months ago (2011-09-15 01:16:02 UTC) #1
jam
9 years, 3 months ago (2011-09-15 01:17:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698