content/browser/plugin_process_host.cc - Issue 7888067: Oops, missed a NULL check. Fix flaky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_process_host.cc

Issue 7888067: Oops, missed a NULL check. Fix flaky test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Undid test, CancelRequests() can only be invoked in destructor. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/plugin_process_host.cc

diff --git a/content/browser/plugin_process_host.cc b/content/browser/plugin_process_host.cc

index f9b4e10ce9de6814f2d78dbb4671e086b048733a..665d4f00030b0babe5fc64a8315f4c1646c07891 100644

--- a/content/browser/plugin_process_host.cc

+++ b/content/browser/plugin_process_host.cc

@@ -327,7 +327,9 @@ void PluginProcessHost::CancelRequests() {

pending_requests_.clear();

while (!sent_requests_.empty()) {

- sent_requests_.front()->OnError();

+ Client* client = sent_requests_.front();

+ if (client)

+ client->OnError();

sent_requests_.pop_front();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »