Chromium Code Reviews
Help | Chromium Project | Sign in
(236)

Issue 7888058: Add check_licenses step to the buildbot. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Paweł Hajdan Jr.
Modified:
2 years, 7 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Add check_licenses step to the buildbot.

BUG=28291
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101313

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Lint Patch
M masters/master.chromium/master_linux_cfg.py View 1 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M masters/master.tryserver.chromium/master.cfg View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M scripts/master/factory/chromium_commands.py View 1 2 chunks +8 lines, -0 lines 0 comments 0 errors Download
M scripts/master/factory/chromium_factory.py View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Paweł Hajdan Jr.
2 years, 7 months ago #1
nsylvain
LGTM with nits http://codereview.chromium.org/7888058/diff/1/masters/master.chromium/master_linux_cfg.py File masters/master.chromium/master_linux_cfg.py (right): http://codereview.chromium.org/7888058/diff/1/masters/master.chromium/master_linux_cfg.py#newcode113 masters/master.chromium/master_linux_cfg.py:113: 'check_licenses', I'd personally remove both check_deps ...
2 years, 7 months ago #2
Paweł Hajdan Jr.
2 years, 7 months ago #3
http://codereview.chromium.org/7888058/diff/1/masters/master.chromium/master_...
File masters/master.chromium/master_linux_cfg.py (right):

http://codereview.chromium.org/7888058/diff/1/masters/master.chromium/master_...
masters/master.chromium/master_linux_cfg.py:113: 'check_licenses',
On 2011/09/15 16:54:49, nsylvain wrote:
> I'd personally remove both check_deps and check_licenses here. up to you
though.

Removed check_licenses then.

http://codereview.chromium.org/7888058/diff/1/masters/master.chromium/master_...
masters/master.chromium/master_linux_cfg.py:218: 'check_licenses',
On 2011/09/15 16:54:49, nsylvain wrote:
> I dont think we need it here.

Done.

http://codereview.chromium.org/7888058/diff/1/scripts/master/factory/chromium...
File scripts/master/factory/chromium_commands.py (right):

http://codereview.chromium.org/7888058/diff/1/scripts/master/factory/chromium...
scripts/master/factory/chromium_commands.py:78: self._check_licenses_tool =
J('src', 'tools', 'checklicenses', 'checklicenses.py')
On 2011/09/15 16:54:49, nsylvain wrote:
> 80 chars

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434