Add check_licenses step to the buildbot.

scripts/master/factory/chromium_commands.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds chromium-specific commands."""
 
 import logging
 import os
@@ skipping 57 matching lines @@
     # Scripts in the private dir.
     self._reliability_tool = J(p_dir, 'reliability_tests.py')
     self._reliability_data = J(p_dir, 'data', 'reliability')
     self._download_and_extract_official_tool = self.PathJoin(
         p_dir, 'get_official_build.py')
 
     # These scripts should be move to the script dir.
     self._check_deps_tool = J('src', 'tools', 'checkdeps', 'checkdeps.py')
     self._check_bins_tool = J('src', 'tools', 'checkbins', 'checkbins.py')
     self._check_perms_tool = J('src', 'tools', 'checkperms', 'checkperms.py')
+    self._check_licenses_tool = J('src', 'tools', 'checklicenses', 'checklicenses.py')

[nsylvain, 2011/09/15 16:54:49]

80 chars

[Paweł Hajdan Jr., 2011/09/15 17:21:06]

Done.

     self._posix_memory_tests_runner = J('src', 'tools', 'valgrind',
                                         'chrome_tests.sh')
     self._win_memory_tests_runner = J('src', 'tools', 'valgrind',
                                       'chrome_tests.bat')
     self._heapcheck_tool = J('src', 'tools', 'heapcheck', 'chrome_tests.sh')
     self._annotated_steps = J('src', 'build', 'buildbot_annotated_steps.py')
     self._nacl_integration_tester_tool = J(
         'src', 'chrome', 'test', 'nacl_test_injection',
         'buildbot_nacl_integration.py')
     # chrome_staging directory, relative to the build directory.
@@ skipping 97 matching lines @@
     cmd = [self._python, self._check_bins_tool, build_dir]
     self.AddTestStep(shell.ShellCommand, 'check_bins', cmd,
                      do_step_if=self.TestStepFilter)
 
   def AddCheckPermsStep(self):
     cmd = [self._python, self._check_perms_tool,
            '--root', self._repository_root]
     self.AddTestStep(shell.ShellCommand, 'check_perms', cmd,
                      do_step_if=self.TestStepFilter)
 
+  def AddCheckLicensesStep(self):
+    cmd = [self._python, self._check_licenses_tool,
+           '--root', self._repository_root]
+    self.AddTestStep(shell.ShellCommand, 'check_licenses', cmd,
+                     do_step_if=self.TestStepFilter)
+
   def AddCheckLKGRStep(self):
     """Check LKGR; if unchanged, cancel the build.
 
     Unlike other "test step" commands, this one can cancel the build
     while still keeping it green.
 
     Note we use "." as a root (which is the same as self.working_dir)
     to make sure a clobber step deletes the saved lkgr file.
     """
     cmd = [self._python, self._check_lkgr_tool, '--root', '.']
@@ skipping 942 matching lines @@
   # ArchiveCommand.createSummary.
   return '%s/%s/%s' % (config.Master.archive_url, archive_type, builder_name)
 
 def _GetSnapshotUrl(factory_properties=None, builder_name='%(build_name)s'):
   if not factory_properties or 'gs_bucket' not in factory_properties:
     return (_GetArchiveUrl('snapshots', builder_name), None)
   gs_bucket = factory_properties['gs_bucket']
   gs_bucket = re.sub(r'^gs://', 'http://commondatastorage.googleapis.com/',
                      gs_bucket)
   return ('%s/index.html?path=%s' % (gs_bucket, builder_name), '/')