Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: build/android/pylib/base/test_run_factory.py

Issue 788753002: [Android] Implement gtest and local in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/base/test_run_factory.py
diff --git a/build/android/pylib/base/test_run_factory.py b/build/android/pylib/base/test_run_factory.py
index 6ccfb37ec95afb146d4fb57072b551440f617da4..9dd932847ce5e5c8e666bf69476f39a43e1b7fd2 100644
--- a/build/android/pylib/base/test_run_factory.py
+++ b/build/android/pylib/base/test_run_factory.py
@@ -2,9 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-def CreateTestRun(_args, _env, _test_instance, error_func):
+from pylib.gtest import gtest_test_instance
+from pylib.gtest import local_device_gtest_run
+from pylib.local.device import local_device_environment
+
+
+def CreateTestRun(_args, env, test_instance, error_func):
+
klundberg 2014/12/09 02:30:47 This empty line seems out of place/unneeded.
jbudorick 2014/12/09 15:46:51 Done.
+ if isinstance(env, local_device_environment.LocalDeviceEnvironment):
+ if isinstance(test_instance, gtest_test_instance.GtestTestInstance):
+ return local_device_gtest_run.LocalDeviceGtestRun(env, test_instance)
- # TODO(jbudorick) Add local gtest test runs
# TODO(jbudorick) Add local instrumentation test runs.
klundberg 2014/12/09 02:30:46 Kinda nitpicky: I know that Randy is adding some s
jbudorick 2014/12/09 15:46:51 Added a TODO(rnephew) for remote_device instrument
- error_func('No test runs are currently supported.')
+
+ error_func('Unable to create test run for %s tests in %s environment'
+ % (str(test_instance), str(env)))

Powered by Google App Engine
This is Rietveld 408576698