Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: build/android/pylib/base/test_run_factory.py

Issue 788753002: [Android] Implement gtest and local in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 def CreateTestRun(_args, _env, _test_instance, error_func): 5 from pylib.gtest import gtest_test_instance
6 from pylib.gtest import local_device_gtest_run
7 from pylib.local.device import local_device_environment
6 8
7 # TODO(jbudorick) Add local gtest test runs 9
10 def CreateTestRun(_args, env, test_instance, error_func):
11
klundberg 2014/12/09 02:30:47 This empty line seems out of place/unneeded.
jbudorick 2014/12/09 15:46:51 Done.
12 if isinstance(env, local_device_environment.LocalDeviceEnvironment):
13 if isinstance(test_instance, gtest_test_instance.GtestTestInstance):
14 return local_device_gtest_run.LocalDeviceGtestRun(env, test_instance)
15
8 # TODO(jbudorick) Add local instrumentation test runs. 16 # TODO(jbudorick) Add local instrumentation test runs.
klundberg 2014/12/09 02:30:46 Kinda nitpicky: I know that Randy is adding some s
jbudorick 2014/12/09 15:46:51 Added a TODO(rnephew) for remote_device instrument
9 error_func('No test runs are currently supported.')
10 17
18 error_func('Unable to create test run for %s tests in %s environment'
19 % (str(test_instance), str(env)))
20
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698