Paper over a crash.

Paper over a crash.

This quick fix is designed to make trunk more stable and to be easy to apply and revert as needed.

BUG=438951
TBR=vabr@chromium.org

Committed: https://crrev.com/2bab693172313788e550f908ff4b3c53623b94d2
Cr-Commit-Position: refs/heads/master@{#308153}

[Evan Stade, 2014-12-10 22:24:37]

estade@chromium.org changed reviewers:
+ nick@chromium.org

[Evan Stade, 2014-12-10 22:24:38]

Hi Nick, I had a conversation with amineer and it seems to be important that we
avert this crash in any way possible. We can wait until your other diagnostic CL
lands and we get some crash dumps for it, then land this CL to make trunk more
stable, then revert this CL while landing any fix we come up with (or new
diagnostic CL), and repeat as necessary.

I'm not 100% confident this CL will stop the crasher but it seems likely.

[ncarter (slow), 2014-12-10 22:48:07]

LGTM, this is reasonable. Let's wait until we get one cycle in the field with
the null-out change I landed today, but the I agree that a short-term
suppression makes sense for our users stability.

[Evan Stade, 2014-12-10 23:11:58]

On 2014/12/10 22:48:07, ncarter wrote:
> LGTM, this is reasonable. Let's wait until we get one cycle in the field with
> the null-out change I landed today, but the I agree that a short-term
> suppression makes sense for our users stability.

yea, will land this tomorrow

[ncarter (slow), 2014-12-11 18:43:15]

Whoops -- it looks like https://codereview.chromium.org/794673002/ hit a CQ
flake and didn't land yesterday. OK to hold off one more day on this?

[Evan Stade, 2014-12-11 18:53:24]

On 2014/12/11 18:43:15, ncarter wrote:
> Whoops -- it looks like https://codereview.chromium.org/794673002/ hit a CQ
> flake and didn't land yesterday. OK to hold off one more day on this?

amineer^

[amineer_google, 2014-12-11 20:11:56]

On 2014/12/11 18:53:24, Evan Stade wrote:
> On 2014/12/11 18:43:15, ncarter wrote:
> > Whoops -- it looks like https://codereview.chromium.org/794673002/ hit a CQ
> > flake and didn't land yesterday. OK to hold off one more day on this?
> 
> amineer^

That's fine, I know we need info to make progress, let's make sure we land this
tomorrow morning though.

[ncarter (slow), 2014-12-12 18:21:11]

OK to land this now. The other CL is out now in canary version 41.0.2248.0.

[Evan Stade, 2014-12-12 19:12:21]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-12-12 19:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788323003/20001

[commit-bot: I haz the power, 2014-12-12 19:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 19:19:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2014-12-12 19:29:18]

estade@chromium.org changed reviewers:
+ vabr@chromium.org

[Evan Stade, 2014-12-12 19:29:26]

TBR vabr for
components/password_manager/content/browser/content_password_manager_driver_factory.cc

[Evan Stade, 2014-12-12 19:29:29]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-12-12 19:30:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788323003/20001

[commit-bot: I haz the power, 2014-12-12 20:40:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 20:41:09]

Patchset 2 (id:??) landed as
https://crrev.com/2bab693172313788e550f908ff4b3c53623b94d2
Cr-Commit-Position: refs/heads/master@{#308153}

[vabr (Chromium), 2014-12-15 09:23:23]

LGTM,
Thanks!
Vaclav