Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.cc

Issue 788323003: Paper over a crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more accurate message in error log Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/content_password_manager_driver_factory.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.cc b/components/password_manager/content/browser/content_password_manager_driver_factory.cc
index 28c56eab09b63d684d264edc832647bebab11970..2ea51ead98e2539ccdca58343fd4a0823e963276 100644
--- a/components/password_manager/content/browser/content_password_manager_driver_factory.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.cc
@@ -101,6 +101,14 @@ void ContentPasswordManagerDriverFactory::DidNavigateAnyFrame(
content::RenderFrameHost* render_frame_host,
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
+ // This shouldn't happen, but is causing a lot of crashes.
+ // See http://crbug.com/438951
+ if (frame_driver_map_.find(render_frame_host) == frame_driver_map_.end()) {
+ LOG(ERROR) << "Could not find ContentPasswordManagerDriver for frame " <<
+ render_frame_host;
+ return;
+ }
+
frame_driver_map_[render_frame_host]->DidNavigateFrame(details, params);
}
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698