Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 78823004: Move PolicyBundle into components/policy/. (Closed)

Created:
7 years, 1 month ago by dconnelly
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Joao da Silva
Visibility:
Public.

Description

Move PolicyBundle into components/policy/. This facilitates the refactoring of chrome/browser/policy into a layered component. Depends on https://codereview.chromium.org/78763002/ BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236747

Patch Set 1 #

Total comments: 2

Patch Set 2 : okay rebase please #

Patch Set 3 : rebase on master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -481 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/forwarding_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/mock_configuration_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/policy_bundle.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/policy/policy_bundle.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/policy/policy_bundle_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M chrome/browser/policy/policy_loader_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/browser/policy/policy_service_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_transformations.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_transformations_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/schema_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/schema_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/test/policy_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/common/external_data_manager.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A + components/policy/core/common/policy_bundle.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/policy_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_bundle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dconnelly
7 years, 1 month ago (2013-11-20 18:30:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/78823004/diff/1/components/policy/core/common/policy_bundle.h File components/policy/core/common/policy_bundle.h (right): https://codereview.chromium.org/78823004/diff/1/components/policy/core/common/policy_bundle.h#newcode18 components/policy/core/common/policy_bundle.h:18: class POLICY_EXPORT PolicyBundle { include policy_export.h
7 years, 1 month ago (2013-11-21 13:52:29 UTC) #2
dconnelly
https://codereview.chromium.org/78823004/diff/1/components/policy/core/common/policy_bundle.h File components/policy/core/common/policy_bundle.h (right): https://codereview.chromium.org/78823004/diff/1/components/policy/core/common/policy_bundle.h#newcode18 components/policy/core/common/policy_bundle.h:18: class POLICY_EXPORT PolicyBundle { On 2013/11/21 13:52:30, jochen wrote: ...
7 years, 1 month ago (2013-11-22 09:04:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/78823004/130001
7 years, 1 month ago (2013-11-22 09:24:01 UTC) #4
commit-bot: I haz the power
Change committed as 236747
7 years, 1 month ago (2013-11-22 11:49:01 UTC) #5
Joao da Silva
7 years, 1 month ago (2013-11-22 17:46:14 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/78823004/diff/130001/chrome/browser/policy/po...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

https://codereview.chromium.org/78823004/diff/130001/chrome/browser/policy/po...
chrome/browser/policy/policy_loader_win_unittest.cc:7: #include <windows.h>
Why?

Powered by Google App Engine
This is Rietveld 408576698