Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2003)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/policy/policy_bundle_unittest.cc

Issue 78823004: Move PolicyBundle into components/policy/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on master Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_bundle.cc ('k') | chrome/browser/policy/policy_loader_mac.cc » ('j') | chrome/browser/policy/policy_loader_win_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/policy_bundle_unittest.cc
diff --git a/chrome/browser/policy/policy_bundle_unittest.cc b/chrome/browser/policy/policy_bundle_unittest.cc
deleted file mode 100644
index 9ca7833c7cd560f0fe492958cfc5120ca5caa525..0000000000000000000000000000000000000000
--- a/chrome/browser/policy/policy_bundle_unittest.cc
+++ /dev/null
@@ -1,260 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/policy/policy_bundle.h"
-
-#include "base/callback.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "components/policy/core/common/external_data_fetcher.h"
-#include "components/policy/core/common/policy_map.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace policy {
-
-namespace {
-
-const char kPolicyClashing0[] = "policy-clashing-0";
-const char kPolicyClashing1[] = "policy-clashing-1";
-const char kPolicy0[] = "policy-0";
-const char kPolicy1[] = "policy-1";
-const char kPolicy2[] = "policy-2";
-const char kExtension0[] = "extension-0";
-const char kExtension1[] = "extension-1";
-const char kExtension2[] = "extension-2";
-const char kExtension3[] = "extension-3";
-
-// Adds test policies to |policy|.
-void AddTestPolicies(PolicyMap* policy) {
- policy->Set("mandatory-user", POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateIntegerValue(123), NULL);
- policy->Set("mandatory-machine", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
- base::Value::CreateStringValue("omg"), NULL);
- policy->Set("recommended-user", POLICY_LEVEL_RECOMMENDED,
- POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
- base::DictionaryValue* dict = new base::DictionaryValue();
- dict->SetBoolean("false", false);
- dict->SetInteger("int", 456);
- dict->SetString("str", "bbq");
- policy->Set("recommended-machine", POLICY_LEVEL_RECOMMENDED,
- POLICY_SCOPE_MACHINE, dict, NULL);
-}
-
-// Adds test policies to |policy| based on the parameters:
-// - kPolicyClashing0 mapped to |value|, user mandatory
-// - kPolicyClashing1 mapped to |value|, with |level| and |scope|
-// - |name| mapped to |value|, user mandatory
-void AddTestPoliciesWithParams(PolicyMap *policy,
- const char* name,
- int value,
- PolicyLevel level,
- PolicyScope scope) {
- policy->Set(kPolicyClashing0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(value), NULL);
- policy->Set(kPolicyClashing1, level, scope,
- base::Value::CreateIntegerValue(value), NULL);
- policy->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(value), NULL);
-}
-
-// Returns true if |bundle| is empty.
-bool IsEmpty(const PolicyBundle& bundle) {
- return bundle.begin() == bundle.end();
-}
-
-} // namespace
-
-TEST(PolicyBundleTest, Get) {
- PolicyBundle bundle;
- EXPECT_TRUE(IsEmpty(bundle));
-
- AddTestPolicies(&bundle.Get(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())));
- EXPECT_FALSE(IsEmpty(bundle));
-
- PolicyMap policy;
- AddTestPolicies(&policy);
- EXPECT_TRUE(bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string())).Equals(policy));
-
- PolicyBundle::const_iterator it = bundle.begin();
- ASSERT_TRUE(it != bundle.end());
- EXPECT_EQ(POLICY_DOMAIN_CHROME, it->first.domain);
- EXPECT_EQ("", it->first.component_id);
- ASSERT_TRUE(it->second);
- EXPECT_TRUE(it->second->Equals(policy));
- ++it;
- EXPECT_TRUE(it == bundle.end());
- EXPECT_TRUE(bundle.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension0)).empty());
-
- EXPECT_FALSE(IsEmpty(bundle));
- bundle.Clear();
- EXPECT_TRUE(IsEmpty(bundle));
-}
-
-TEST(PolicyBundleTest, SwapAndCopy) {
- PolicyBundle bundle0;
- PolicyBundle bundle1;
-
- AddTestPolicies(&bundle0.Get(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())));
- AddTestPolicies(&bundle0.Get(
- PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0)));
- EXPECT_FALSE(IsEmpty(bundle0));
- EXPECT_TRUE(IsEmpty(bundle1));
-
- PolicyMap policy;
- AddTestPolicies(&policy);
- EXPECT_TRUE(bundle0.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string())).Equals(policy));
- EXPECT_TRUE(bundle0.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension0)).Equals(policy));
-
- bundle0.Swap(&bundle1);
- EXPECT_TRUE(IsEmpty(bundle0));
- EXPECT_FALSE(IsEmpty(bundle1));
-
- EXPECT_TRUE(bundle1.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string())).Equals(policy));
- EXPECT_TRUE(bundle1.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension0)).Equals(policy));
-
- bundle0.CopyFrom(bundle1);
- EXPECT_FALSE(IsEmpty(bundle0));
- EXPECT_FALSE(IsEmpty(bundle1));
- EXPECT_TRUE(bundle0.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string())).Equals(policy));
- EXPECT_TRUE(bundle0.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension0)).Equals(policy));
-}
-
-TEST(PolicyBundleTest, MergeFrom) {
- // Each bundleN has kExtensionN. Each bundle also has policy for
- // chrome and kExtension3.
- // |bundle0| has the highest priority, |bundle2| the lowest.
- PolicyBundle bundle0;
- PolicyBundle bundle1;
- PolicyBundle bundle2;
-
- PolicyMap policy0;
- AddTestPoliciesWithParams(
- &policy0, kPolicy0, 0u, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
- bundle0.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .CopyFrom(policy0);
- bundle0.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0))
- .CopyFrom(policy0);
- bundle0.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension3))
- .CopyFrom(policy0);
-
- PolicyMap policy1;
- AddTestPoliciesWithParams(
- &policy1, kPolicy1, 1u, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE);
- bundle1.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .CopyFrom(policy1);
- bundle1.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1))
- .CopyFrom(policy1);
- bundle1.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension3))
- .CopyFrom(policy1);
-
- PolicyMap policy2;
- AddTestPoliciesWithParams(
- &policy2, kPolicy2, 2u, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER);
- bundle2.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .CopyFrom(policy2);
- bundle2.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2))
- .CopyFrom(policy2);
- bundle2.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension3))
- .CopyFrom(policy2);
-
- // Merge in order of decreasing priority.
- PolicyBundle merged;
- merged.MergeFrom(bundle0);
- merged.MergeFrom(bundle1);
- merged.MergeFrom(bundle2);
- PolicyBundle empty_bundle;
- merged.MergeFrom(empty_bundle);
-
- // chrome and kExtension3 policies are merged:
- // - kPolicyClashing0 comes from bundle0, which has the highest priority;
- // - kPolicyClashing1 comes from bundle1, which has the highest level/scope
- // combination;
- // - kPolicyN are merged from each bundle.
- PolicyMap expected;
- expected.Set(kPolicyClashing0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(0), NULL);
- expected.Set(kPolicyClashing1, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
- base::Value::CreateIntegerValue(1), NULL);
- expected.Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(0), NULL);
- expected.Set(kPolicy1, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(1), NULL);
- expected.Set(kPolicy2, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(2), NULL);
- EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string())).Equals(expected));
- EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension3)).Equals(expected));
- // extension0 comes only from bundle0.
- EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension0)).Equals(policy0));
- // extension1 comes only from bundle1.
- EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension1)).Equals(policy1));
- // extension2 comes only from bundle2.
- EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
- kExtension2)).Equals(policy2));
-}
-
-TEST(PolicyBundleTest, Equals) {
- PolicyBundle bundle;
- AddTestPolicies(&bundle.Get(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())));
- AddTestPolicies(&bundle.Get(
- PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0)));
-
- PolicyBundle other;
- EXPECT_FALSE(bundle.Equals(other));
- other.CopyFrom(bundle);
- EXPECT_TRUE(bundle.Equals(other));
-
- AddTestPolicies(&bundle.Get(
- PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1)));
- EXPECT_FALSE(bundle.Equals(other));
- other.CopyFrom(bundle);
- EXPECT_TRUE(bundle.Equals(other));
- AddTestPolicies(&other.Get(
- PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2)));
- EXPECT_FALSE(bundle.Equals(other));
-
- other.CopyFrom(bundle);
- bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .Set(kPolicy0,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123),
- NULL);
- EXPECT_FALSE(bundle.Equals(other));
- other.CopyFrom(bundle);
- EXPECT_TRUE(bundle.Equals(other));
- bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .Set(kPolicy0,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_MACHINE,
- base::Value::CreateIntegerValue(123),
- NULL);
- EXPECT_FALSE(bundle.Equals(other));
-
- // Test non-const Get().
- bundle.Clear();
- other.Clear();
- PolicyMap& policy_map =
- bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
- EXPECT_TRUE(bundle.Equals(other));
- policy_map.Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123), NULL);
- EXPECT_FALSE(bundle.Equals(other));
-}
-
-} // namespace policy
« no previous file with comments | « chrome/browser/policy/policy_bundle.cc ('k') | chrome/browser/policy/policy_loader_mac.cc » ('j') | chrome/browser/policy/policy_loader_win_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698