Use request_url() from SecurityInterstitialPage in SSL interstitials.

Use request_url() from SecurityInterstitialPage in SSL interstitials.

BUG=438476
Committed: https://crrev.com/8275cdce102ed409178d4581074c78032f7c8ce4
Cr-Commit-Position: refs/heads/master@{#309580}

[meacer, 2014-12-23 18:55:37]

meacer@chromium.org changed reviewers:
+ felt@chromium.org

[meacer, 2014-12-23 18:55:38]

felt: Can you PTAL? Thanks.

[felt, 2014-12-23 19:05:43]

lgtm; was request_url_ never getting set at all? (why was it only breaking for
some interstitials and not others?)

https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
File chrome/browser/ssl/ssl_blocking_page.h (left):

https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
chrome/browser/ssl/ssl_blocking_page.h:101: const GURL request_url_;
ah, is the problem that this was not getting set in the constructor?

[meacer, 2014-12-23 19:08:02]

On 2014/12/23 19:05:43, felt wrote:
> lgtm; was request_url_ never getting set at all? (why was it only breaking for
> some interstitials and not others?)
> 
>
https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
> File chrome/browser/ssl/ssl_blocking_page.h (left):
> 
>
https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
> chrome/browser/ssl/ssl_blocking_page.h:101: const GURL request_url_;
> ah, is the problem that this was not getting set in the constructor?

I removed it from both interstitials when I added SecurityInterstitialPage, but
I suspect it was mistakenly reintroduced during a merge.

[meacer, 2014-12-23 19:08:13]

https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
File chrome/browser/ssl/ssl_blocking_page.h (left):

https://codereview.chromium.org/788183006/diff/1/chrome/browser/ssl/ssl_block...
chrome/browser/ssl/ssl_blocking_page.h:101: const GURL request_url_;
On 2014/12/23 19:05:43, felt wrote:
> ah, is the problem that this was not getting set in the constructor?

Exactly.

[meacer, 2014-12-23 19:08:20]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2014-12-23 19:09:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788183006/1

[commit-bot: I haz the power, 2014-12-23 21:05:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-23 21:06:07]

Patchset 1 (id:??) landed as
https://crrev.com/8275cdce102ed409178d4581074c78032f7c8ce4
Cr-Commit-Position: refs/heads/master@{#309580}