Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 788183006: Use request_url() from SecurityInterstitialPage in SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 void NotifyDenyCertificate(); 91 void NotifyDenyCertificate();
92 void NotifyAllowCertificate(); 92 void NotifyAllowCertificate();
93 93
94 // Used to query the HistoryService to see if the URL is in history. For UMA. 94 // Used to query the HistoryService to see if the URL is in history. For UMA.
95 void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit); 95 void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit);
96 96
97 base::Callback<void(bool)> callback_; 97 base::Callback<void(bool)> callback_;
98 98
99 const int cert_error_; 99 const int cert_error_;
100 const net::SSLInfo ssl_info_; 100 const net::SSLInfo ssl_info_;
101 const GURL request_url_;
felt 2014/12/23 19:05:43 ah, is the problem that this was not getting set i
meacer 2014/12/23 19:08:13 Exactly.
102 // There are two ways for the user to override an interstitial: 101 // There are two ways for the user to override an interstitial:
103 // 102 //
104 // overridable_) By clicking on "Advanced" and then "Proceed". 103 // overridable_) By clicking on "Advanced" and then "Proceed".
105 // - This corresponds to "the user can override using the UI". 104 // - This corresponds to "the user can override using the UI".
106 // danger_overridable_) By typing the word "danger". 105 // danger_overridable_) By typing the word "danger".
107 // - This is an undocumented workaround. 106 // - This is an undocumented workaround.
108 // - This can be set to "false" dynamically to prevent the behaviour. 107 // - This can be set to "false" dynamically to prevent the behaviour.
109 const bool overridable_; 108 const bool overridable_;
110 bool danger_overridable_; 109 bool danger_overridable_;
111 // Has the site requested strict enforcement of certificate errors? 110 // Has the site requested strict enforcement of certificate errors?
(...skipping 13 matching lines...) Expand all
125 // For Chrome Experience Sampling Platform: this maintains event state. 124 // For Chrome Experience Sampling Platform: this maintains event state.
126 scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_; 125 scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
127 #endif 126 #endif
128 127
129 content::NotificationRegistrar registrar_; 128 content::NotificationRegistrar registrar_;
130 129
131 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage); 130 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
132 }; 131 };
133 132
134 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 133 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698