content/browser/service_worker/service_worker_unregister_job.h - Issue 788073007: Cleanup geofence registrations when a service worker is unregistered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_unregister_job.h

Issue 788073007: Cleanup geofence registrations when a service worker is unregistered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly improve mock usage in test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.cc ('K') | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_unregister_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_unregister_job.h

diff --git a/content/browser/service_worker/service_worker_unregister_job.h b/content/browser/service_worker/service_worker_unregister_job.h

index fef9c272de64afc7922beb20022cc7777eb06581..ac488bc16263991bfc2a51e2ee254332989cd62a 100644

--- a/content/browser/service_worker/service_worker_unregister_job.h

+++ b/content/browser/service_worker/service_worker_unregister_job.h

@@ -27,7 +27,8 @@ class ServiceWorkerStorage;

// ServiceWorkerRegistration itself.

class ServiceWorkerUnregisterJob : public ServiceWorkerRegisterJobBase {

public:

- typedef base::Callback<void(ServiceWorkerStatusCode status)>

+ typedef base::Callback<void(int64 registration_id,

+ ServiceWorkerStatusCode status)>

UnregistrationCallback;

ServiceWorkerUnregisterJob(base::WeakPtr<ServiceWorkerContextCore> context,

@@ -48,9 +49,9 @@ class ServiceWorkerUnregisterJob : public ServiceWorkerRegisterJobBase {

void OnRegistrationFound(

ServiceWorkerStatusCode status,

const scoped_refptr<ServiceWorkerRegistration>& registration);

- void Complete(ServiceWorkerStatusCode status);

- void CompleteInternal(ServiceWorkerStatusCode status);

- void ResolvePromise(ServiceWorkerStatusCode status);

+ void Complete(int64 registration_id, ServiceWorkerStatusCode status);

+ void CompleteInternal(int64 registration_id, ServiceWorkerStatusCode status);

+ void ResolvePromise(int64 registration_id, ServiceWorkerStatusCode status);

base::WeakPtr<ServiceWorkerContextCore> context_;

const GURL pattern_;