content/browser/service_worker/service_worker_context_core.cc - Issue 788073007: Cleanup geofence registrations when a service worker is unregistered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 788073007: Cleanup geofence registrations when a service worker is unregistered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly improve mock usage in test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geofencing/geofencing_manager.cc ('K') | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_context_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index 91a77f3477c9556bf91e87830ab5e721521325a0..51baeb650f08c0bd25959a671bb9bc0f35532db9 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -310,11 +310,12 @@ void ServiceWorkerContextCore::RegistrationComplete(

void ServiceWorkerContextCore::UnregistrationComplete(

const GURL& pattern,

const ServiceWorkerContextCore::UnregistrationCallback& callback,

+ int64 registration_id,

ServiceWorkerStatusCode status) {

callback.Run(status);

if (observer_list_.get()) {

observer_list_->Notify(&ServiceWorkerContextObserver::OnRegistrationDeleted,

michaeln 2015/01/09 22:58:41 Seems odd that this notif can happen even if nothi

Marijn Kruisselbrink 2015/01/09 23:13:15 Yes, that does seem odd (but not anything introduc

- pattern);

+ registration_id, pattern);

}