Replace RenderFullscreen with top layer - Take II

Source/core/css/resolver/StyleAdjuster.cpp

Index: Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/Source/core/css/resolver/StyleAdjuster.cpp b/Source/core/css/resolver/StyleAdjuster.cpp
index b89efa29db5f8431d53608348e330ccbc5e27b04..7f87ebfde9041a61b192ecf377bf605221f18811 100644
--- a/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/Source/core/css/resolver/StyleAdjuster.cpp
@@ -34,13 +34,16 @@
 #include "core/dom/ContainerNode.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
+#include "core/dom/Fullscreen.h"
+#include "core/frame/FrameHost.h"
+#include "core/frame/FrameView.h"
+#include "core/frame/Settings.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLTableCellElement.h"
 #include "core/html/HTMLTextAreaElement.h"
-#include "core/frame/FrameView.h"
-#include "core/frame/Settings.h"
+#include "core/page/Page.h"
 #include "core/rendering/RenderReplaced.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/rendering/style/GridPosition.h"
@@ -172,6 +175,18 @@ void StyleAdjuster::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty
         adjustStyleForFirstLetter(style);
 
         adjustStyleForDisplay(style, parentStyle);
+
+        if (e && e->document().page()->settings().pinchVirtualViewportEnabled()) {
+            if (Fullscreen::isActiveFullScreenElement(*e)) {
+                // We need to size the fullscreen element to the inner viewport and not to the
+                // outer viewport (what percentage would do). Unfortunately CSS can't handle
+                // that as we don't expose this information. FIXME: We should find a way to
+                // get this standardized.
+                IntSize viewportSize = e->document().page()->frameHost().pinchViewport().size();
+                style->setWidth(Length(viewportSize.width(), Fixed));
+                style->setHeight(Length(viewportSize.height(), Fixed));

[rune, 2014/12/16 19:10:24]

This looks very weird to me. If I understand correctly, this means that you'll
get a reflow on every pinch zoom change and effectively you'll get a zoom
behavior for fullscreen on Android that behaves like a desktop type of zoom
where you scale the CSS pixel size.

What's the reasoning behind this behavior? I couldn't see anything in the spec
about this.

My immediate thought would be to size the CSS viewport to the initial viewport
(@viewport rule in the fullscreen.css for Android) and restrict zooming in the
viewport rule as well, if that's what we want.

[aelias_OOO_until_Jul13, 2014/12/16 19:34:33]

We don't support pinch zoom in fullscreen; page scale factor is always locked to
1 when fullscreen starts.  The reason is that for embedded videos on desktop
pages on Android, the outer viewport is sized to the content width of the page
(so that fixed-position elements are sized properly as they don't expect a small
pinched viewport).  We want the fullscreened video to be sized to the true
physical size of the screen instead.  But there wasn't any way to express this
in CSS.

+            }
+        }
     } else {
         adjustStyleForFirstLetter(style);
     }