Replace RenderFullscreen with top layer - Take II

Source/core/css/resolver/StyleAdjuster.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 16 matching lines @@
  */
 
 #include "config.h"
 #include "core/css/resolver/StyleAdjuster.h"
 
 #include "core/HTMLNames.h"
 #include "core/SVGNames.h"
 #include "core/dom/ContainerNode.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
+#include "core/dom/Fullscreen.h"
+#include "core/frame/FrameHost.h"
+#include "core/frame/FrameView.h"
+#include "core/frame/Settings.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLTableCellElement.h"
 #include "core/html/HTMLTextAreaElement.h"
-#include "core/frame/FrameView.h"
-#include "core/frame/Settings.h"
+#include "core/page/Page.h"
 #include "core/rendering/RenderReplaced.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/rendering/style/GridPosition.h"
 #include "core/rendering/style/RenderStyle.h"
 #include "core/rendering/style/RenderStyleConstants.h"
 #include "core/svg/SVGSVGElement.h"
 #include "platform/Length.h"
 #include "platform/transforms/TransformOperations.h"
 #include "wtf/Assertions.h"
 
@@ skipping 111 matching lines @@
 
         // Absolute/fixed positioned elements, floating elements and the document element need block-like outside display.
         if (style->hasOutOfFlowPosition() || style->isFloating() || (e && e->document().documentElement() == e))
             style->setDisplay(equivalentBlockDisplay(style->display(), style->isFloating(), !m_useQuirksModeStyles));
 
         // We don't adjust the first letter style earlier because we may change the display setting in
         // adjustStyeForTagName() above.
         adjustStyleForFirstLetter(style);
 
         adjustStyleForDisplay(style, parentStyle);
+
+        if (e && e->document().page()->settings().pinchVirtualViewportEnabled()) {
+            if (Fullscreen::isActiveFullScreenElement(*e)) {
+                // We need to size the fullscreen element to the inner viewport and not to the
+                // outer viewport (what percentage would do). Unfortunately CSS can't handle
+                // that as we don't expose this information. FIXME: We should find a way to
+                // get this standardized.
+                IntSize viewportSize = e->document().page()->frameHost().pinchViewport().size();
+                style->setWidth(Length(viewportSize.width(), Fixed));
+                style->setHeight(Length(viewportSize.height(), Fixed));

[rune, 2014/12/16 19:10:24]

This looks very weird to me. If I understand correctly, this means that you'll
get a reflow on every pinch zoom change and effectively you'll get a zoom
behavior for fullscreen on Android that behaves like a desktop type of zoom
where you scale the CSS pixel size.

What's the reasoning behind this behavior? I couldn't see anything in the spec
about this.

My immediate thought would be to size the CSS viewport to the initial viewport
(@viewport rule in the fullscreen.css for Android) and restrict zooming in the
viewport rule as well, if that's what we want.

[aelias_OOO_until_Jul13, 2014/12/16 19:34:33]

We don't support pinch zoom in fullscreen; page scale factor is always locked to
1 when fullscreen starts.  The reason is that for embedded videos on desktop
pages on Android, the outer viewport is sized to the content width of the page
(so that fixed-position elements are sized properly as they don't expect a small
pinched viewport).  We want the fullscreened video to be sized to the true
physical size of the screen instead.  But there wasn't any way to express this
in CSS.

+            }
+        }
     } else {
         adjustStyleForFirstLetter(style);
     }
 
     // Make sure our z-index value is only applied if the object is positioned.
     if (style->position() == StaticPosition && !parentStyleForcesZIndexToCreateStackingContext(parentStyle))
         style->setHasAutoZIndex();
 
     // Auto z-index becomes 0 for the root element and transparent objects. This prevents
     // cases where objects that should be blended as a single unit end up with a non-transparent
@@ skipping 290 matching lines @@
     if (style->writingMode() != TopToBottomWritingMode && (style->display() == BOX || style->display() == INLINE_BOX))
         style->setWritingMode(TopToBottomWritingMode);
 
     if (parentStyle->isDisplayFlexibleOrGridBox()) {
         style->setFloating(NoFloat);
         style->setDisplay(equivalentBlockDisplay(style->display(), style->isFloating(), !m_useQuirksModeStyles));
     }
 }
 
 }