[osx] Adapt mirrored-shortcut handling to 10.9 differences.

[osx] Adapt mirrored-shortcut handling to 10.9 differences.

Hebrew keyboard shortcuts for 10.9 mirror brackets and parens
differently than 10.8.  Convert to a more general mapping table which
doesn't make assumptions about the codes for the mirrored elements.

BUG=319182
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238197

[jeremy, 2013-11-21 09:38:44]

LGTM++ thank you for fixing this Scott!!

[Scott Hess - ex-Googler, 2013-11-22 23:13:26]

+thakis@ for chrome/OWNERS

[Nico, 2013-11-23 05:23:00]

Are there any layouts where [ and ] (or { and }) are on the same key? E.g. so
that shift-[ would be ]? Would this patch break these layouts?

[Scott Hess - ex-Googler, 2013-11-27 22:35:12]

On 2013/11/23 05:23:00, Nico wrote:
> Are there any layouts where [ and ] (or { and }) are on the same key? E.g. so
> that shift-[ would be ]? Would this patch break these layouts?

I'm finding myself unable to even think of how one would answer this question. 
Selecting each of the possible keyboards and looking at them could potentially
tell you if there was a case where this does happen, but for a number of them I
don't know how such key codes are even generated.  Is there any way to ask such
a question in bulk?

AFAICT, there's no identifying info in NSEvent.  You could perhaps figure out
what some global setting or another is, but I'm not entirely sure we want to do
that in a keystroke handler.

[Nico, 2013-11-27 22:36:27]

lgtm then, I guess?


On Wed, Nov 27, 2013 at 2:35 PM, <shess@chromium.org> wrote:

> On 2013/11/23 05:23:00, Nico wrote:
>
>> Are there any layouts where [ and ] (or { and }) are on the same key?
>> E.g. so
>> that shift-[ would be ]? Would this patch break these layouts?
>>
>
> I'm finding myself unable to even think of how one would answer this
> question.
> Selecting each of the possible keyboards and looking at them could
> potentially
> tell you if there was a case where this does happen, but for a number of
> them I
> don't know how such key codes are even generated.  Is there any way to ask
> such
> a question in bulk?
>
> AFAICT, there's no identifying info in NSEvent.  You could perhaps figure
> out
> what some global setting or another is, but I'm not entirely sure we want
> to do
> that in a keystroke handler.
>
> https://codereview.chromium.org/78783006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Scott Hess - ex-Googler, 2013-11-27 22:43:47]

I want to say that this will only happen in a keyboard-shortcut type context, so
it would only cause problems when they are trying to command-[ or Command-]. 
But I'm in a maze of twisty passages which all look the same, and find myself
uncertain.  Jeremy, do you think that that is correct?

On 2013/11/27 22:36:27, Nico wrote:
> lgtm then, I guess?
> 
> 
> On Wed, Nov 27, 2013 at 2:35 PM, <mailto:shess@chromium.org> wrote:
> 
> > On 2013/11/23 05:23:00, Nico wrote:
> >
> >> Are there any layouts where [ and ] (or { and }) are on the same key?
> >> E.g. so
> >> that shift-[ would be ]? Would this patch break these layouts?
> >>
> >
> > I'm finding myself unable to even think of how one would answer this
> > question.
> > Selecting each of the possible keyboards and looking at them could
> > potentially
> > tell you if there was a case where this does happen, but for a number of
> > them I
> > don't know how such key codes are even generated.  Is there any way to ask
> > such
> > a question in bulk?
> >
> > AFAICT, there's no identifying info in NSEvent.  You could perhaps figure
> > out
> > what some global setting or another is, but I'm not entirely sure we want
> > to do
> > that in a keystroke handler.
> >
> > https://codereview.chromium.org/78783006/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[jeremy, 2013-11-28 12:23:50]

On 2013/11/27 22:43:47, shess wrote:
> I want to say that this will only happen in a keyboard-shortcut type context,
so
> it would only cause problems when they are trying to command-[ or Command-]. 
> But I'm in a maze of twisty passages which all look the same, and find myself
> uncertain.  Jeremy, do you think that that is correct?

I agree, if we happen upon a keyboard layout for which this doesn't work we can
try to mitigate, for now, in my mind this is enough of a corner case that
landing this CL is OK.
Thanks again for looking into this and writing up a fix!

[Scott Hess - ex-Googler, 2013-12-02 19:19:13]

On 2013/11/28 12:23:50, jeremy wrote:
> On 2013/11/27 22:43:47, shess wrote:
> > I want to say that this will only happen in a keyboard-shortcut type
context,
> so
> > it would only cause problems when they are trying to command-[ or Command-].

> > But I'm in a maze of twisty passages which all look the same, and find
myself
> > uncertain.  Jeremy, do you think that that is correct?
> 
> I agree, if we happen upon a keyboard layout for which this doesn't work we
can
> try to mitigate, for now, in my mind this is enough of a corner case that
> landing this CL is OK.
> Thanks again for looking into this and writing up a fix!

OK, I'm going to go for it.  Hopefully the problematic layout(s) will be ones
with a few helpful users rather than millions of vocal users.

[Heck, I didn't even know Command-[ and Command-] before this bug.]

[commit-bot: I haz the power, 2013-12-02 19:33:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/78783006/1

[commit-bot: I haz the power, 2013-12-02 21:52:36]

Change committed as 238197