Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

Issue 78783006: [osx] Adapt mirrored-shortcut handling to 10.9 differences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
diff --git a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
index cdf39568aa19bd6150790d43926f2d47bd37bad3..ee931b74a0fc0d72cb46cda79d6f965195799dfe 100644
--- a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
+++ b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
@@ -182,9 +182,12 @@ TEST(GlobalKeyboardShortcuts, KeyCharacterForEvent) {
// cmd-'z' / cmd-shift-';' on dvorak-qwerty
EXPECT_EQ('z', KeyCharacterForEvent(
KeyEvent(true, true, false, false, @"z", @":")));
- // cmd-shift-'[' in an RTL context.
+ // cmd-shift-'[' in an RTL context pre 10.9.
EXPECT_EQ('{', KeyCharacterForEvent(
KeyEvent(true, true, false, false, @"{", @"}")));
+ // cmd-shift-'[' in an RTL context on 10.9.
+ EXPECT_EQ('{', KeyCharacterForEvent(
+ KeyEvent(true, true, false, false, @"[", @"}")));
// Test if getting dead-key events return 0 and do not hang.
EXPECT_EQ(0, KeyCharacterForEvent(
KeyEvent(false, false, false, false, @"", @"")));
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698