Reland of Allow RunShellCommand to work even with very large commands

Reland of Allow RunShellCommand to work even with very large commands

Currently RunShellCommand may not work if the command passed to
adb.Shell is too large (e.g. > 1024). This CL addresses this
issue, allowing to run even very large commands, by first writing
the command as a shell script and then running it.

Original CL: https://codereview.chromium.org/751063002/

BUG=436133
Committed: https://crrev.com/4463a715a053c99da3537e580c22bd61ac9be7c3
Cr-Commit-Position: refs/heads/master@{#313496}

[perezju, 2014-12-15 15:48:58]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org

[perezju, 2014-12-15 15:48:59]

Rebased against master, so the DeviceTempFile changes are no longer part of this
CL.

Also, although it does not directly depend on it, perhaps best to land *after*
https://codereview.chromium.org/801283004

https://codereview.chromium.org/787813002/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/787813002/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:467: cmd[:100])
I've noted that running large shell commands in this way (like the ones already
done by hand for PushChanged files) annoyingly hide the actual command being run
under "adb shell 'sh -c /path/to/temp123456.sh'".

So I thought it's best to log at least a portion of the command, so that we can
get an idea of what's going on when reading the logs.

[jbudorick, 2014-12-15 23:18:29]

Looking at the delta, I'm not sure how this fixes the issues the original CL
had. Am I missing something?

(Obviously, your landing order comment would avoid that particular issue, but
something was clearly wrong...)

https://codereview.chromium.org/787813002/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/787813002/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:467: cmd[:100])
On 2014/12/15 15:48:59, perezju wrote:
> I've noted that running large shell commands in this way (like the ones
already
> done by hand for PushChanged files) annoyingly hide the actual command being
run
> under "adb shell 'sh -c /path/to/temp123456.sh'".
> 
> So I thought it's best to log at least a portion of the command, so that we
can
> get an idea of what's going on when reading the logs.

sgtm

[perezju, 2014-12-16 11:05:54]

On 2014/12/15 23:18:29, jbudorick wrote:
> Looking at the delta, I'm not sure how this fixes the issues the original CL
> had. Am I missing something?
> 
> (Obviously, your landing order comment would avoid that particular issue, but
> something was clearly wrong...)

No, as far as I could tell, there weren't any particular issues with the
changes in RunShellCommand. All of that worked correctly and pretty much as
expected. The failure last time was caused by trying to create a temp file
at an inaccessible directory after the wipe, but that problem has also been
solved in DeviceTempFile at CL 793653002.

The analysis of the issues of the previous CL can be found here:
https://code.google.com/p/chromium/issues/detail?id=436133#c3

[jbudorick, 2014-12-16 14:06:54]

Ah, ok. lgtm

[perezju, 2015-01-28 11:42:09]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2015-01-28 11:43:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787813002/40001

[commit-bot: I haz the power, 2015-01-28 11:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 11:54:45]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[perezju, 2015-01-28 12:30:56]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2015-01-28 12:31:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787813002/40001

[commit-bot: I haz the power, 2015-01-28 13:14:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-28 13:15:56]

Patchset 3 (id:??) landed as
https://crrev.com/4463a715a053c99da3537e580c22bd61ac9be7c3
Cr-Commit-Position: refs/heads/master@{#313496}