Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 801283004: Provision devices: use ReadFile/WriteFile to load/restore adb keys (Closed)

Created:
6 years ago by perezju
Modified:
5 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provision devices: use ReadFile/WriteFile to load/restore adb keys Instead of using a cat/echo combination to read and write adb keys one by one, we can now use the dedicated and more robust ReadFile/WriteFile. Depends on: https://codereview.chromium.org/806843002/ BUG=436133 Committed: https://crrev.com/eda10ed8796186f0781b81cbb8a1951ab013b7a6 Cr-Commit-Position: refs/heads/master@{#313274}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M build/android/provision_devices.py View 1 chunk +2 lines, -7 lines 1 comment Download

Messages

Total messages: 15 (6 generated)
perezju
(hopefully) straightforward, but depends on landing the interface change for DeviceUtils.ReadFile
6 years ago (2014-12-15 15:33:21 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/801283004/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/801283004/diff/1/build/android/provision_devices.py#newcode122 build/android/provision_devices.py:122: adb_keys = device.ReadFile(constants.ADB_KEYS_FILE, as_root=True) These will both now ...
6 years ago (2014-12-15 23:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283004/1
5 years, 11 months ago (2015-01-27 10:43:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/99306)
5 years, 11 months ago (2015-01-27 11:58:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283004/1
5 years, 11 months ago (2015-01-27 12:08:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/115625) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/99306)
5 years, 11 months ago (2015-01-27 12:08:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283004/1
5 years, 11 months ago (2015-01-27 14:32:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 14:33:26 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 14:34:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eda10ed8796186f0781b81cbb8a1951ab013b7a6
Cr-Commit-Position: refs/heads/master@{#313274}

Powered by Google App Engine
This is Rietveld 408576698