Issue 787803006: Fix tools/android_stack_parser/stack and use it in skydb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787803006: Fix tools/android_stack_parser/stack and use it in skydb (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix tools/android_stack_parser/stack and use it in skydb This adds a skydb print_crash command which will dump the symbolicated stack trace of all crashes found in adb logcat output from the android device. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d04b5939aac2687d1fde7984a4a5f1b93f8ed993

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
	M	sky/tools/skydb	View		5 chunks	+17 lines, -2 lines	1 comment	Download
	M	tools/android_stack_parser/stack	View		1 chunk	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

https://codereview.chromium.org/787803006/diff/1/sky/tools/skydb File sky/tools/skydb (right): https://codereview.chromium.org/787803006/diff/1/sky/tools/skydb#newcode322 sky/tools/skydb:322: subprocess.call(['adb', 'logcat', '-d', '-s'] + TAGS) This makes skydb ...

5 years, 11 months ago (2015-01-13 22:58:02 UTC) #2

eseidel

5 years, 11 months ago (2015-01-13 23:03:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d04b5939aac2687d1fde7984a4a5f1b93f8ed993 (presubmit successful).

Expand Messages | Collapse Messages